From 3d72a5d05d22e1ca66de0bc6aa5eb6026c6dc8cd Mon Sep 17 00:00:00 2001
From: James Maes <james@kof22.com>
Date: Wed, 14 Oct 2026 23:07:25 -0500
Subject: [PATCH] test(help): compare the help bundle version with the artifact
 version, not a hardcoded SNAPSHOT

The bundle version is now Maven-filtered, so a literal SNAPSHOT in the test
fails every release build. Surefire passes the artifact version in
qbit.artifactVersion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 pom.xml                                                | 10 ++++++++++
 .../com/kingsrook/qbits/cdn/CdnHelpBundleTest.java     |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 1789237..ed193b2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -124,6 +124,16 @@
          </resource>
       </resources>
       <plugins>
+         <!-- the artifact version, for the help bundle version test -->
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+               <systemPropertyVariables combine.children="append">
+                  <qbit.artifactVersion>${project.version}</qbit.artifactVersion>
+               </systemPropertyVariables>
+            </configuration>
+         </plugin>
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
diff --git a/src/test/java/com/kingsrook/qbits/cdn/CdnHelpBundleTest.java b/src/test/java/com/kingsrook/qbits/cdn/CdnHelpBundleTest.java
index 6d4915e..d4466b1 100644
--- a/src/test/java/com/kingsrook/qbits/cdn/CdnHelpBundleTest.java
+++ b/src/test/java/com/kingsrook/qbits/cdn/CdnHelpBundleTest.java
@@ -65,7 +65,7 @@ class CdnHelpBundleTest
       assertThat(instance.getTable("helpContent")).isNull();
       var bundle = HelpBundles.of(instance).getBundles().get(0);
       assertThat(bundle.getId()).isEqualTo("qbit-cdn");
-      assertThat(bundle.getVersion()).isEqualTo("0.1.0-SNAPSHOT");
+      assertThat(bundle.getVersion()).as("the help bundle carries the artifact version").isEqualTo(System.getProperty("qbit.artifactVersion"));
       assertThat(bundle.getLayer()).isEqualTo(HelpBundleLayer.QBIT);
       assertThat(bundle.getEntries()).extracting(entry -> entry.getKey()).doesNotHaveDuplicates();
       // Core's gate does not require widgets or possible-value sources yet.
-- 
2.54.0