QRun-IO/qbit-collaboration
3
0 Fork 0
Code Issues 3 Pull Requests 10 Actions Packages Projects Releases 6 Wiki Activity

fix(attachments): use only qbit-object-storage's api package #11

Merged
KofTwentyTwo merged 1 commits from fix/object-storage-api-only into develop 2026-10-14 01:01:34 +00:00
Conversation 0 Commits 1 Files Changed 1
+5 -2
KofTwentyTwo commented 2026-10-14 00:58:46 +00:00 (Migrated from github.com)
Copy link
Copy source

Summary

This removes qbit-collaboration's only edge into a non-api class of qbit-object-storage (qbit-bom#10, guardrail G1-arch). AttachmentStorage.maxBytes read the bucket's upload cap through StorageBucket.config().getMaxUploadBytes(), which returns the non-api StorageBucketConfig.

Behavior after this change:

  • Collaboration enforces only its own per-table maxBytes setting (default 100 MB).
  • Object storage still enforces the bucket's cap when the object is put. An oversized upload is still refused, but by storage rather than up front.

I've asked the remediation agent for a StorageBucket.maxUploadBytes() accessor in object-storage's api package. When it ships, collaboration will switch to it, so the panel can show the smaller of the two limits.

Test plan

  • ./mvnw -o verify: green, with the coverage gates unchanged.
  • CircleCI test_only.

🤖 Generated with Claude Code

## Summary This removes qbit-collaboration's only edge into a non-`api` class of qbit-object-storage (qbit-bom#10, guardrail G1-arch). `AttachmentStorage.maxBytes` read the bucket's upload cap through `StorageBucket.config().getMaxUploadBytes()`, which returns the non-`api` `StorageBucketConfig`. Behavior after this change: - Collaboration enforces only its own per-table `maxBytes` setting (default 100 MB). - Object storage still enforces the bucket's cap when the object is put. An oversized upload is still refused, but by storage rather than up front. I've asked the remediation agent for a `StorageBucket.maxUploadBytes()` accessor in object-storage's `api` package. When it ships, collaboration will switch to it, so the panel can show the smaller of the two limits. ## Test plan - [x] `./mvnw -o verify`: green, with the coverage gates unchanged. - [ ] CircleCI `test_only`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-collaboration#11