QRun-IO/qbit-collaboration
3
0 Fork 0
Code Issues 3 Pull Requests 10 Actions Packages Projects Releases 6 Wiki Activity

DeleteAttachmentsProcess Review/Delete default constructors read QContext during instance validation #20

New Issue
Closed
opened 2026-10-14 17:44:17 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-14 17:44:17 +00:00 (Migrated from github.com)
Copy link
Copy source

Found while adopting 0.1.0-RC.1 in a host app (kof22).

DeleteAttachmentsProcess.Review and .Delete default constructors build an AttachmentsService that reads QContext (session and instance). QQQ instantiates the transform and load code references during context-free instance validation, so validation fails unless the host swaps in subclasses that pass new AttachmentsService(config, new AttachmentStorage()) explicitly.

Expected: constructing the steps needs no QContext. Resolve the service lazily inside run/preRun, where a context exists.

The host currently works around it with a tagged STAND-IN subclass, to be removed in the next RC.

🤖 Generated with Claude Code

Found while adopting 0.1.0-RC.1 in a host app (kof22). `DeleteAttachmentsProcess.Review` and `.Delete` default constructors build an `AttachmentsService` that reads `QContext` (session and instance). QQQ instantiates the transform and load code references during context-free instance validation, so validation fails unless the host swaps in subclasses that pass `new AttachmentsService(config, new AttachmentStorage())` explicitly. **Expected:** constructing the steps needs no `QContext`. Resolve the service lazily inside `run`/`preRun`, where a context exists. The host currently works around it with a tagged STAND-IN subclass, to be removed in the next RC. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-collaboration#20