fix(upload-journal): accept Amazon Aurora PostgreSQL (full_page_writes=off) [release/1.1] #64
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: QRun-IO/qbit-collaboration#64
Reference in new issue
Block a user
Defect
The retained upload journal's PostgreSQL 17 qualification (
PostgresJournalDatabase) refuses every call unlesscurrent_setting('full_page_writes')ison. Amazon Aurora PostgreSQL reportsfull_page_writes = off(measured on engine 17.9: context sighup, source default, not present in the cluster parameter group), so the journal cannot be used there.Rule implemented
to_regprocedure('aurora_version()') IS NOT NULL. It is true on Aurora, false on stock PostgreSQL 17, and never raises.full_page_writesqualifies when it ison, or when it isoffand that column is true (PostgresJournalDatabase.tornPagesPrevented).full_page_writes = offis still refused. On Aurora,synchronous_commit,fsync, recovery state, read-only state, isolation, time zone, lock timeout (1 to 5000 ms), server version, catalog, table and index checks are exactly as before. The refusal message is unchanged.Why it is safe on Aurora and not on stock PostgreSQL: stock PostgreSQL repairs a partly written page from the full page image in the write-ahead log, so
offcan lose committed rows after a crash. Aurora's storage layer does not write torn pages, and the parameter cannot be changed there.Known limit, documented in
docs/RETAINED-UPLOAD-JOURNAL.md: the detection is a name lookup, so a function namedaurora_version()on the search path of a stock server is reported as Aurora.Other places with the same assumption
full_page_writesis read in one place only,PostgresJournalDatabase.MySqlJournalDatabase(MySQL 8.4innodb_doublewrite, Aurora MySQL refused) and the H2WRITE_DELAY=0check are different backends and are not changed.Tests
PostgresJournalDatabaseTest(always runs, no database): the pure decision, and that the settings query detects Aurora only throughto_regprocedureas its last column.PostgresUploadJournalTest(opt-in with-DpostgresJournalTests=true, realpostgres:17container), three new cases: the settings query returns the detection column as the application role without aborting the transaction;full_page_writes = offis refused on stock PostgreSQL and accepted once Aurora is detected; Aurora withsynchronous_commitoff orfsyncoff is still refused.aurora_version()is created in the test database soto_regprocedureresolves, andfull_page_writes(andfsync) are turned off on the stock server withALTER SYSTEMand a reload. The container no longer passesfsync=onandfull_page_writes=onon the command line, because a command-line value cannot be changed by a reload; both are set toonwithALTER SYSTEMat start and before every test.Verification
Local, Windows 11, Java 21, Docker 29.9.2, commit
c6edde7:./mvnw -B -DpostgresJournalTests=true -Dtest=PostgresUploadJournalTest,PostgresJournalDatabaseTest test: 18 tests run, 0 failures, 0 errors, 0 skipped (15 real PostgreSQL 17 cases, 3 pure cases); Checkstyle reported 0 violations../mvnw -B verify: in progress when this pull request was opened; the result is added as a comment.Targets
release/1.1because that branch publishes the1.1.0release candidates: its head is thev1.1.0-RC.1tag with<revision>1.1.0-RC.1</revision>, and a push to it publishes1.1.0-RC.2. This is the only change between1.1.0-RC.1and1.1.0-RC.2. The same change is opened againstdevelopseparately.Not merged, tagged or released by the author.
🤖 Generated with Claude Code
The PostgreSQL 17 journal qualification refused every call on Amazon Aurora PostgreSQL, which reports full_page_writes=off and does not expose the parameter in its cluster parameter group. - The settings query gains an eleventh column, to_regprocedure('aurora_version()') IS NOT NULL, which is true on Aurora, false on stock PostgreSQL 17 and never raises. - full_page_writes=off is accepted only when that column is true. Stock PostgreSQL with full_page_writes=off is still refused, and synchronous_commit, fsync, recovery, isolation, time zone and lock timeout are unchanged on Aurora. - The decision is the pure function tornPagesPrevented, covered by an always-on unit test. The opt-in real PostgreSQL 17 suite simulates Aurora with a function named aurora_version() and full_page_writes=off on the server. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>Verification of commit
c6edde7(this pull request's head).Local, Windows 11, Java 21, Docker 29.9.2:
./mvnw -B -DpostgresJournalTests=true -Dtest=PostgresUploadJournalTest,PostgresJournalDatabaseTest test: 18 tests run, 0 failures, 0 errors, 0 skipped. Checkstyle: 0 violations../mvnw -B verify, first run: 335 tests run, 0 failures, 1 error, 26 skipped, BUILD FAILURE. The error wasAttachmentTransactionsPostgresTest.deleteOuterRollbackPreservesAttachment,java.net.SocketException: No buffer space available (maximum connections reached?): connectwhile opening a connection to its test container. That test and class are not touched by this change../mvnw -B verify, second run, same commit, nothing changed: 335 tests run, 0 failures, 0 errors, 26 skipped, Checkstyle 0 violations,All coverage checks have been met, BUILD SUCCESS. The 26 skipped are the opt-in suites (MySqlUploadJournalTest11,PostgresUploadJournalTest15), which are off by default.Gitea Actions run 7338 (
build.yaml, push of this branch): completed, success, first attempt. Its log showsBuild kind: verify,Tests run: 335, Failures: 0, Errors: 0, Skipped: 26,BUILD SUCCESS. CI does not enablepostgresJournalTests, so the three new real-PostgreSQL cases ran locally only; the three new pure cases ran in CI.