From 31ce528064ebe960a3e3162ff4cb45c999509cc2 Mon Sep 17 00:00:00 2001
From: James Maes <james@kof22.com>
Date: Wed, 14 Oct 2026 23:07:29 -0500
Subject: [PATCH] test(help): compare the help bundle version with the artifact
 version, not a hardcoded SNAPSHOT

The bundle version is now Maven-filtered, so a literal SNAPSHOT in the test
fails every release build. Surefire passes the artifact version in
qbit.artifactVersion.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---
 pom.xml                                                | 10 ++++++++++
 .../CollaborationTablesGuardrailTest.java              |  2 +-
 2 files changed, 11 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index f98879a..7fa52b4 100644
--- a/pom.xml
+++ b/pom.xml
@@ -131,6 +131,16 @@
          </resource>
       </resources>
       <plugins>
+         <!-- the artifact version, for the help bundle version test -->
+         <plugin>
+            <groupId>org.apache.maven.plugins</groupId>
+            <artifactId>maven-surefire-plugin</artifactId>
+            <configuration>
+               <systemPropertyVariables combine.children="append">
+                  <qbit.artifactVersion>${project.version}</qbit.artifactVersion>
+               </systemPropertyVariables>
+            </configuration>
+         </plugin>
          <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-checkstyle-plugin</artifactId>
diff --git a/src/test/java/com/kingsrook/qbits/collaboration/CollaborationTablesGuardrailTest.java b/src/test/java/com/kingsrook/qbits/collaboration/CollaborationTablesGuardrailTest.java
index 566efbb..07ef1e0 100644
--- a/src/test/java/com/kingsrook/qbits/collaboration/CollaborationTablesGuardrailTest.java
+++ b/src/test/java/com/kingsrook/qbits/collaboration/CollaborationTablesGuardrailTest.java
@@ -146,7 +146,7 @@ class CollaborationTablesGuardrailTest extends PersonalServiceFixture
       assertThat(HelpBundles.of(instance).getBundles()).singleElement().satisfies(bundle ->
       {
          assertThat(bundle.getId()).isEqualTo("qbit-collaboration");
-         assertThat(bundle.getVersion()).isEqualTo("0.1.0-SNAPSHOT");
+         assertThat(bundle.getVersion()).as("the help bundle carries the artifact version").isEqualTo(System.getProperty("qbit.artifactVersion"));
          assertThat(bundle.getEntries()).anyMatch(entry -> entry.getKey().equals("app:collaboration;slot:help"));
       });
    }
-- 
2.54.0