QRun-IO/qbit-marketing
3
0 Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 7 Wiki Activity

Depend on qbit-assistant-provider-api only; reuse the published OpenAI provider #9

New Issue
Closed
opened 2026-10-14 00:14:35 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-14 00:14:35 +00:00 (Migrated from github.com)
Copy link
Copy source

The pom has qbit-assistant in compile scope, and the code imports internals:

  • MarketingAgentService.java:28-39;
  • OpenAiCompatibleModelProvider.java:33-37;
  • MarketingQBitConfig.java:24-25.

Once qbit-assistant publishes the provider API module:

  • depend on that module only;
  • drop the local OpenAiCompatibleModelProvider in favour of qbit-assistant-provider-openai.

Source: Architecture review QRun-IO/qqq#1150 (docs/ARCHITECTURE-REVIEW-2026-10-13.md), finding F5.

The pom has `qbit-assistant` in compile scope, and the code imports internals: - `MarketingAgentService.java:28-39`; - `OpenAiCompatibleModelProvider.java:33-37`; - `MarketingQBitConfig.java:24-25`. Once qbit-assistant publishes the provider API module: - depend on that module only; - drop the local `OpenAiCompatibleModelProvider` in favour of `qbit-assistant-provider-openai`. Source: Architecture review QRun-IO/qqq#1150 (docs/ARCHITECTURE-REVIEW-2026-10-13.md), finding F5.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
wontfix
This will not be worked on
No labels architecture
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-marketing#9