QRun-IO/qbit-quick-search
3
0 Fork 0
Code Issues 2 Pull Requests 4 Actions Packages Projects Releases 14 Wiki Activity

Record a failed event when the listener's in-transaction re-read fails #13

New Issue
Closed
opened 2026-10-06 12:23:18 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-06 12:23:18 +00:00 (Migrated from github.com)
Copy link
Copy source

If fetchCurrentRecords in QuickSearchRecordChangeListener throws (for example a possible-value translation against an unavailable backend), the exception escapes onRecordsChanged before publish. QQQ logs it at warn and the update is dropped with no quickSearchFailedEvent row, contrary to the class contract. The basepull watermark is the only backstop, and there is none for tables without a timestamp field.

Fix: catch around the re-read and call recordFailures with the primary keys from the event's records. A LinkageError from the lazy publisher (optional AWS SDK missing in DEGRADED startup) has the same gap.

Found in the PR #10 review.

Part of #12.

If `fetchCurrentRecords` in `QuickSearchRecordChangeListener` throws (for example a possible-value translation against an unavailable backend), the exception escapes `onRecordsChanged` before publish. QQQ logs it at warn and the update is dropped with no `quickSearchFailedEvent` row, contrary to the class contract. The basepull watermark is the only backstop, and there is none for tables without a timestamp field. Fix: catch around the re-read and call `recordFailures` with the primary keys from the event's records. A `LinkageError` from the lazy publisher (optional AWS SDK missing in `DEGRADED` startup) has the same gap. Found in the PR #10 review. Part of #12.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-quick-search#13