QRun-IO/qbit-quick-search
3
0 Fork 0
Code Issues 2 Pull Requests 4 Actions Packages Projects Releases 14 Wiki Activity

realTimeErrorCount is never incremented #53

New Issue
Closed
opened 2026-10-14 15:34:56 +00:00 by KofTwentyTwo · 0 comments
KofTwentyTwo commented 2026-10-14 15:34:56 +00:00 (Migrated from github.com)
Copy link
Copy source

Found while triaging the kof22 in-app help pass (KofTwentyTwo/Website-Backend#196).

What: the index status row's realTimeErrorCount (metadata/QuickSearchTableMetaDataHelper.java:102, read by diagnostics/StatusDiagnostics.java:110 and the status API api/QuickSearchStatus.java:75) is only ever written as 0 (processes/AbstractIndexingStep.java:182, processes/config/AddSearchIndexSteps.java:283, config/QuickSearchConfigPrimer.java:259). When real-time indexing fails, listeners/QuickSearchRecordChangeListener.java:274 logs and records quick_search_failed_event rows but never increments the count, so status always shows 0 real-time errors.

Fix: increment the table's count by the number of failed events when they are recorded (never failing the user's write), keep the reset on full reindex or basepull, and say so in the field's help text.

Found while triaging the kof22 in-app help pass (KofTwentyTwo/Website-Backend#196). **What:** the index status row's `realTimeErrorCount` (`metadata/QuickSearchTableMetaDataHelper.java:102`, read by `diagnostics/StatusDiagnostics.java:110` and the status API `api/QuickSearchStatus.java:75`) is only ever written as 0 (`processes/AbstractIndexingStep.java:182`, `processes/config/AddSearchIndexSteps.java:283`, `config/QuickSearchConfigPrimer.java:259`). When real-time indexing fails, `listeners/QuickSearchRecordChangeListener.java:274` logs and records `quick_search_failed_event` rows but never increments the count, so status always shows 0 real-time errors. **Fix:** increment the table's count by the number of failed events when they are recorded (never failing the user's write), keep the reset on full reindex or basepull, and say so in the field's help text.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-quick-search#53