From 034d77b5ac303d74c9b98c8abcfc9aef59fafd71 Mon Sep 17 00:00:00 2001
From: James Maes <james@kof22.com>
Date: Thu, 5 Nov 2026 10:41:02 -0600
Subject: [PATCH] build: make the reactor root the single version source of
 every module

The release pipeline rewrites <revision> only in the ROOT pom.xml (the pinned legacy calculate_version.sh) and nothing passes -Drevision
(java-verify runs plain `mvn verify` with MAVEN_ARGS only from caller inputs), but every module declared its own <revision>0.1.0-SNAPSHOT</revision>
and did not inherit the root. After an RC rewrite the root would say the RC while the modules still built as the SNAPSHOT, so capture
(target/<artifact>-<root version>.jar) would find no JAR and the publisher (one version per reactor) would reject the reactor.

Standard Maven CI-friendly inheritance: the root takes the modules' own former parent (qbit-build-parent 2.0.0, identical for all four
modules), every module's parent becomes the root (version ${revision}, relativePath ../pom.xml) and the per-module <revision> properties are
removed. Each module's inherited build configuration is unchanged (child -> root -> the same qbit-build-parent); modules still build on their
own through the relative parent. Metadata audit: the root declares Apache-2.0 and base declares it too (unchanged); rdbms, middleware and
github declared no license and inherited qbit-build-parent's AGPL-3.0, so they now state that same license explicitly to keep their published
metadata exactly as before (the repository LICENSE is Apache: whether those three should be Apache is an owner decision, not changed here).
All GAVs, module boundaries, flatten plugin, dependencies, tests and sources are unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
---
 base/pom.xml       | 3 +--
 github/pom.xml     | 5 +++--
 middleware/pom.xml | 5 +++--
 pom.xml            | 6 +++++-
 rdbms/pom.xml      | 5 +++--
 5 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/base/pom.xml b/base/pom.xml
index ad85a70..02a85ed 100644
--- a/base/pom.xml
+++ b/base/pom.xml
@@ -2,7 +2,7 @@
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <!-- Same parent (qbit-build-parent 2.0.0) as released qbit-printing 1.0.0; QQQ baseline is the public 4.1.0-RC.21. -->
-   <parent><groupId>com.kingsrook</groupId><artifactId>qbit-build-parent</artifactId><version>2.0.0</version><relativePath/></parent>
+   <parent><groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-reactor</artifactId><version>${revision}</version><relativePath>../pom.xml</relativePath></parent>
    <groupId>com.kingsrook.qbits</groupId>
    <artifactId>qbit-scripting</artifactId>
    <version>${revision}</version>
@@ -10,7 +10,6 @@
    <description>QQQ QBit: shared compiled-TypeScript script projects, immutable builds, capability broker and record hooks. Execution requires an external isolated worker.</description>
    <licenses><license><name>Apache License, Version 2.0</name><url>https://www.apache.org/licenses/LICENSE-2.0</url></license></licenses>
    <properties>
-      <revision>0.1.0-SNAPSHOT</revision>
       <maven.compiler.release>21</maven.compiler.release>
       <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
       <qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version>
diff --git a/github/pom.xml b/github/pom.xml
index 1d90a70..94486b5 100644
--- a/github/pom.xml
+++ b/github/pom.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
- <parent><groupId>com.kingsrook</groupId><artifactId>qbit-build-parent</artifactId><version>2.0.0</version><relativePath/></parent>
+ <parent><groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-reactor</artifactId><version>${revision}</version><relativePath>../pom.xml</relativePath></parent>
  <groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-github</artifactId><version>${revision}</version>
- <properties><revision>0.1.0-SNAPSHOT</revision><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version></properties>
+ <licenses><license><name>GNU Affero General Public License v3.0</name><url>https://www.gnu.org/licenses/agpl-3.0-standalone.html</url><distribution>repo</distribution></license></licenses>
+ <properties><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version></properties>
  <dependencyManagement><dependencies>
       <dependency><groupId>com.kingsrook.qqq</groupId><artifactId>qqq-backend-core</artifactId><version>${qqq.core.version}</version></dependency>
       <dependency><groupId>com.kingsrook.qqq</groupId><artifactId>qqq-backend-module-rdbms</artifactId><version>${qqq.core.version}</version></dependency>
diff --git a/middleware/pom.xml b/middleware/pom.xml
index 018b9c2..9fad01f 100644
--- a/middleware/pom.xml
+++ b/middleware/pom.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
- <parent><groupId>com.kingsrook</groupId><artifactId>qbit-build-parent</artifactId><version>2.0.0</version><relativePath/></parent>
+ <parent><groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-reactor</artifactId><version>${revision}</version><relativePath>../pom.xml</relativePath></parent>
  <groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-middleware</artifactId><version>${revision}</version>
- <properties><revision>0.1.0-SNAPSHOT</revision><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version></properties>
+ <licenses><license><name>GNU Affero General Public License v3.0</name><url>https://www.gnu.org/licenses/agpl-3.0-standalone.html</url><distribution>repo</distribution></license></licenses>
+ <properties><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version></properties>
  <dependencyManagement><dependencies>
       <dependency><groupId>com.kingsrook.qqq</groupId><artifactId>qqq-backend-core</artifactId><version>${qqq.core.version}</version></dependency>
       <dependency><groupId>com.kingsrook.qqq</groupId><artifactId>qqq-backend-module-rdbms</artifactId><version>${qqq.core.version}</version></dependency>
diff --git a/pom.xml b/pom.xml
index 7060a19..fe1b625 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1,7 +1,11 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
-   <!-- Aggregator only. It is not a parent of any module: every module keeps its own dependency boundary and installs on its own. -->
+   <!-- Reactor root AND parent of every module, so the one <revision> below is the single version source: the release pipeline rewrites only this root property and
+        passes no -Drevision, so a module that declared its own revision would stay at the SNAPSHOT. The root keeps the modules' own former parent (qbit-build-parent
+        2.0.0), so each module's inherited build configuration is unchanged; each module still keeps its own dependency boundary and can be built on its own
+        (mvn -f <module>/pom.xml resolves this parent through ../pom.xml). -->
+   <parent><groupId>com.kingsrook</groupId><artifactId>qbit-build-parent</artifactId><version>2.0.0</version><relativePath/></parent>
    <groupId>com.kingsrook.qbits</groupId>
    <artifactId>qbit-scripting-reactor</artifactId>
    <version>${revision}</version>
diff --git a/rdbms/pom.xml b/rdbms/pom.xml
index a897f9b..3f7ca9b 100644
--- a/rdbms/pom.xml
+++ b/rdbms/pom.xml
@@ -1,9 +1,10 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
  <modelVersion>4.0.0</modelVersion>
- <parent><groupId>com.kingsrook</groupId><artifactId>qbit-build-parent</artifactId><version>2.0.0</version><relativePath/></parent>
+ <parent><groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-reactor</artifactId><version>${revision}</version><relativePath>../pom.xml</relativePath></parent>
  <groupId>com.kingsrook.qbits</groupId><artifactId>qbit-scripting-rdbms</artifactId><version>${revision}</version>
- <properties><revision>0.1.0-SNAPSHOT</revision><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version><qqq.postgres.version>4.1.0-RC.21</qqq.postgres.version></properties>
+ <licenses><license><name>GNU Affero General Public License v3.0</name><url>https://www.gnu.org/licenses/agpl-3.0-standalone.html</url><distribution>repo</distribution></license></licenses>
+ <properties><maven.compiler.release>21</maven.compiler.release><maven.compiler.proc>none</maven.compiler.proc><qqq.version>4.1.0-RC.21</qqq.version><qqq.core.version>4.1.0-RC.21</qqq.core.version><qqq.postgres.version>4.1.0-RC.21</qqq.postgres.version></properties>
  <dependencyManagement><dependencies>
       <dependency><groupId>com.kingsrook.qqq</groupId><artifactId>qqq-backend-core</artifactId><version>${qqq.core.version}</version></dependency>