QRun-IO/qbit-sql-workbench
3
0 Fork 0
Code Issues 1 Pull Requests 2 Actions Packages Projects Releases 8 Wiki Activity

fix(screens): plain child-list labels, backend and cell-type pickers, read-only keys and JSON #14

Merged
KofTwentyTwo merged 2 commits from feature/record-screen-polish into develop 2026-10-12 21:08:17 +00:00
Conversation 0 Commits 2 Files Changed 11
+296 -22
KofTwentyTwo commented 2026-10-12 20:53:26 +00:00 (Migrated from github.com)
Copy link
Copy source

Record-screen audit follow-ups (KofTwentyTwo/Website-Backend#130 audit):

  • Notebook child lists: Cells, Shares, Snapshots, Versions (not join names).
  • defaultBackendName / cell backendName: possible-value source from WorkbenchBackends.listTargets(); customizers reject invalid values.
  • cellType: SQL/MARKDOWN enum PVS. cellKey: read-only.
  • Execution parametersJson: read-only JSON code editor.

Tests: 122 unit tests pass; JaCoCo 93.9% / 100%. The Postgres integration tests need Docker (run in CI). Checkstyle header warnings on the two new files are the existing stale header template (same as every other file).

Implemented with Codex, reviewed by Claude.

🤖 Generated with Claude Code

Record-screen audit follow-ups (KofTwentyTwo/Website-Backend#130 audit): - Notebook child lists: Cells, Shares, Snapshots, Versions (not join names). - `defaultBackendName` / cell `backendName`: possible-value source from `WorkbenchBackends.listTargets()`; customizers reject invalid values. - `cellType`: SQL/MARKDOWN enum PVS. `cellKey`: read-only. - Execution `parametersJson`: read-only JSON code editor. Tests: 122 unit tests pass; JaCoCo 93.9% / 100%. The Postgres integration tests need Docker (run in CI). Checkstyle header warnings on the two new files are the existing stale header template (same as every other file). Implemented with Codex, reviewed by Claude. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-sql-workbench#14