QRun-IO/qbit-webhooks
3
0 Fork 0
Code Issues Pull Requests 3 Actions Packages Projects Releases 9 Wiki Activity

fix: qbit metadata version comes from the build #22

Merged
KofTwentyTwo merged 1 commits from fix/producer-version-from-build into develop 2026-10-15 06:42:57 +00:00
Conversation 0 Commits 1 Files Changed 6
+51 -2
KofTwentyTwo commented 2026-10-15 06:27:47 +00:00 (Migrated from github.com)
Copy link
Copy source

The producer hardcoded its version, so released artifacts reported a stale literal or -SNAPSHOT as the qbit's metadata version.

Fix: this follows the authentik pattern. A Maven-filtered qbit-webhooks.properties holds version=${project.version}, and the producer loads it. The tests assert that the producer version, the help bundle version and the artifact version are equal (surefire passes qbit.artifactVersion).

Codex notes:
Changed six files: pom.xml, qbit-webhooks.properties, WebhooksQBitProducer.java, both producer/help-bundle tests, and CHANGELOG.md.

  • ./mvnw.cmd -q verify passed.
  • RC.99 proof: all 9 version tests passed with 1.0.0-RC.99.
  • POM restored exactly to intended changes; ${revision} preserved.
  • No commit or push.

Second Brain save was blocked by the vault being outside writable roots.

Low priority: this rides the repo's next RC.

🤖 Generated with Claude Code

The producer hardcoded its version, so released artifacts reported a stale literal or `-SNAPSHOT` as the qbit's metadata version. **Fix:** this follows the authentik pattern. A Maven-filtered `qbit-webhooks.properties` holds `version=${project.version}`, and the producer loads it. The tests assert that the producer version, the help bundle version and the artifact version are equal (surefire passes `qbit.artifactVersion`). **Codex notes:** Changed six files: `pom.xml`, `qbit-webhooks.properties`, `WebhooksQBitProducer.java`, both producer/help-bundle tests, and `CHANGELOG.md`. - `./mvnw.cmd -q verify` passed. - RC.99 proof: all 9 version tests passed with `1.0.0-RC.99`. - POM restored exactly to intended changes; `${revision}` preserved. - No commit or push. Second Brain save was blocked by the vault being outside writable roots. Low priority: this rides the repo's next RC. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-webhooks#22