From d03c902f58850056c234479443ee62f5284d2d10 Mon Sep 17 00:00:00 2001 From: James Maes Date: Wed, 14 Oct 2026 23:07:56 -0500 Subject: [PATCH] test(help): compare the help bundle version with the artifact version, not a hardcoded SNAPSHOT The bundle version is now Maven-filtered, so a literal SNAPSHOT in the test fails every release build. Surefire passes the artifact version in qbit.artifactVersion. Co-Authored-By: Claude Opus 5.5 --- pom.xml | 10 ++++++++++ .../qbits/webhooks/WebhooksHelpBundleTest.java | 2 +- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/pom.xml b/pom.xml index bb978bc..8757b64 100644 --- a/pom.xml +++ b/pom.xml @@ -160,6 +160,16 @@ + + + org.apache.maven.plugins + maven-surefire-plugin + + + ${project.version} + + + org.apache.maven.plugins maven-checkstyle-plugin diff --git a/src/test/java/com/kingsrook/qbits/webhooks/WebhooksHelpBundleTest.java b/src/test/java/com/kingsrook/qbits/webhooks/WebhooksHelpBundleTest.java index bc62873..3118f05 100644 --- a/src/test/java/com/kingsrook/qbits/webhooks/WebhooksHelpBundleTest.java +++ b/src/test/java/com/kingsrook/qbits/webhooks/WebhooksHelpBundleTest.java @@ -75,7 +75,7 @@ class WebhooksHelpBundleTest assertThat(HelpBundles.of(instance).getBundles()).singleElement().satisfies(bundle -> { assertThat(bundle.getId()).isEqualTo("qbit-webhooks"); - assertThat(bundle.getVersion()).isEqualTo("1.0.0-SNAPSHOT"); + assertThat(bundle.getVersion()).as("the help bundle carries the artifact version").isEqualTo(System.getProperty("qbit.artifactVersion")); }); } } -- 2.54.0