Compare commits

...
Author SHA1 Message Date
james.maesandClaude Opus 4.7 10782d6333 ci(actions): make Typecheck step blocking
PR #165 fixed the one real strict-undefined error in SegmentedRing.tsx;
the other ~30 errors reported in CI run 25797533005 were downstream of
`TS2307: Cannot find module '@jarvis/bus'` and resolve automatically
once `scripts/build-webview.sh` produces the bus package's
`dist/index.d.ts` (which CI already runs before typecheck).

Removes `continue-on-error: true` from the Typecheck step so typecheck
regressions block CI going forward.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 07:37:26 -05:00
james.maesandClaude Opus 4.7 f9c630e431 fix(hud): strict-undefined in SegmentedRing instance-matrix loop (#165)
`initialMatrices[i]` is provably defined because the loop bound is
`i < tickCount` and `initialMatrices.length === tickCount`. TS doesn't
track that, so use a non-null assertion to silence TS18048.

The other ~30 errors reported in CI run 25797533005 were all downstream
of `TS2307: Cannot find module '@jarvis/bus'` — they disappear once
`pnpm install` + `bash scripts/build-webview.sh` generates the bus
package's `dist/index.d.ts`. No code change needed for those.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 07:35:50 -05:00
2 changed files with 7 additions and 8 deletions

No files matched your search

+6 -7
View File
@@ -94,14 +94,13 @@ jobs:
# both find a working HUD bundle.
- name: Build HUD bundle (produces @jarvis/bus dist + App/Resources/webview/)
run: bash scripts/build-webview.sh
# Typecheck currently surfaces ~30 pre-existing strict-undefined errors
# (TS18048) in src/hud/{CoreGlow,Reticle,RingMesh,SegmentedRing}.tsx and
# related files. These are real but pre-existed and were masked because
# only vitest ran locally — not `tsc --noEmit`. Marked `continue-on-error`
# until the focused cleanup PR lands. See v0.2 issue for the cleanup.
- name: Typecheck (non-blocking until v0.2 strict-undefined cleanup)
# Typecheck is blocking. The historical ~30 errors reported in CI run
# 25797533005 were almost entirely downstream of `TS2307: Cannot find
# module '@jarvis/bus'` and disappear once `build-webview.sh` runs above
# (which produces `packages/bus/dist/index.d.ts`). The one real strict-
# undefined error in SegmentedRing.tsx was fixed in PR #165.
- name: Typecheck
working-directory: webview
continue-on-error: true
run: pnpm -r typecheck
- name: Test (vitest)
working-directory: webview
@@ -88,7 +88,7 @@ export function SegmentedRing({
if (!appliedRef.current) {
for (let i = 0; i < tickCount; i++) {
const m = initialMatrices[i]
const m = initialMatrices[i]!
tmpMatrix.compose(m.pos, m.quat, m.scale)
meshRef.current.setMatrixAt(i, tmpMatrix)
}