ci(actions): make Typecheck step blocking #166

2026-05-13T12:37:48Z

KofTwentyTwo commented

2026-05-13 12:37:48 +00:00

(Migrated from github.com)

Summary

PR #165 fixed the one real strict-undefined error (SegmentedRing.tsx:92); the other ~30 errors reported in CI run 25797533005 were downstream of TS2307: Cannot find module '@jarvis/bus' and resolve automatically once scripts/build-webview.sh produces the bus dist (which CI already runs before typecheck).
Removes continue-on-error: true from the Typecheck step so future typecheck regressions block CI.

Test plan

Typecheck step on PR #165 (with continue-on-error) passed with the fix
CI on this PR confirms the Typecheck step is now blocking and still passes

Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com

## Summary - PR #165 fixed the one real strict-undefined error (`SegmentedRing.tsx:92`); the other ~30 errors reported in CI run 25797533005 were downstream of `TS2307: Cannot find module '@jarvis/bus'` and resolve automatically once `scripts/build-webview.sh` produces the bus dist (which CI already runs before typecheck). - Removes `continue-on-error: true` from the Typecheck step so future typecheck regressions block CI. ## Test plan - [x] Typecheck step on PR #165 (with continue-on-error) passed with the fix - [ ] CI on this PR confirms the Typecheck step is now blocking and still passes Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/Jarvis#166