docs: scrub Phase-7 + JarvisBusWorld doc drift (#19, #45) #195

Merged
KofTwentyTwo merged 2 commits from docs/v0.2-wave-1-doc-drift into develop 2026-05-14 14:51:03 +00:00
KofTwentyTwo commented 2026-05-14 14:28:45 +00:00 (Migrated from github.com)

Summary

Second PR in the v0.2 Wave 1 sequence (per docs/superpowers/specs/2026-05-14-v0.2-wave-1-sequencing-design.md). Pure documentation cleanup — no behavioural change to either subsystem.

  • #19 — packages/Memory/Sources/Memory/MemoryStore.swift: five Phase-7 hedge phrases (Plan 07-02 wires, Plan 07-03 wires, Plan 07-06, etc.) rewritten to describe live code. The 2026-05-11 D-5/D-6 markers and the "Boot policy (changed 2026-05-11)" doc are preserved unchanged.
  • #45 — JarvisBusWorld references scrubbed across Bus source, HUD source, AppDelegate, and bus tests. The duck-type isJarvisBusShape guard CODE is unchanged; only the comment rationale is rewritten (defensive-double-install inside one page world, not cross-world attach). New boundary gate scripts/check-no-jarvis-bus-world-references.sh enforces no regressions.

#45 unexpected finding

WebviewBridgeTests.test_scriptMessageHandlerIsRegisteredUnderConfiguredName was silently broken: it removed a script handler from WKContentWorld.world(name: "JarvisBusWorld") while the bridge actually registered against .page. removeScriptMessageHandler doesn't throw on absent, so the "registration-is-evidence-of-success" assertion was effectively a no-op since fb41c5f. Fixed to use .page.

Bundle rebuild + version bump

webview/packages/bus/dist/bridge.{js,d.ts} rebuilt via pnpm --filter @jarvis/bus build — not committed (dist/ is untracked; regenerated by scripts/build-webview.sh on every Xcode invocation). Patch version 0.0.0 → 0.0.1.

Test plan

  • Local: swift build --package-path packages/Bus and --package-path packages/Memory clean
  • Local: pnpm --filter @jarvis/bus test — 37/37 pass
  • Local: bash scripts/check-no-jarvis-bus-world-references.sh — PASS
  • Local: bash scripts/check-bus-protocol-version.sh — PASS
  • Local: bash scripts/check-bus-harness-parity.sh — PASS
  • CI: boundary-gates green (new gate auto-discovered)
  • CI: full SPM + webview matrix green

Non-goals

Closes #19
Closes #45

## Summary Second PR in the v0.2 Wave 1 sequence (per `docs/superpowers/specs/2026-05-14-v0.2-wave-1-sequencing-design.md`). Pure documentation cleanup — no behavioural change to either subsystem. - **#19** — `packages/Memory/Sources/Memory/MemoryStore.swift`: five Phase-7 hedge phrases (`Plan 07-02 wires`, `Plan 07-03 wires`, `Plan 07-06`, etc.) rewritten to describe live code. The 2026-05-11 D-5/D-6 markers and the "Boot policy (changed 2026-05-11)" doc are preserved unchanged. - **#45** — `JarvisBusWorld` references scrubbed across Bus source, HUD source, AppDelegate, and bus tests. The duck-type `isJarvisBusShape` guard CODE is unchanged; only the comment rationale is rewritten (defensive-double-install inside one page world, not cross-world attach). New boundary gate `scripts/check-no-jarvis-bus-world-references.sh` enforces no regressions. ### #45 unexpected finding `WebviewBridgeTests.test_scriptMessageHandlerIsRegisteredUnderConfiguredName` was silently broken: it removed a script handler from `WKContentWorld.world(name: "JarvisBusWorld")` while the bridge actually registered against `.page`. `removeScriptMessageHandler` doesn't throw on absent, so the "registration-is-evidence-of-success" assertion was effectively a no-op since `fb41c5f`. Fixed to use `.page`. ### Bundle rebuild + version bump `webview/packages/bus/dist/bridge.{js,d.ts}` rebuilt via `pnpm --filter @jarvis/bus build` — not committed (dist/ is untracked; regenerated by `scripts/build-webview.sh` on every Xcode invocation). Patch version 0.0.0 → 0.0.1. ## Test plan - [x] Local: `swift build --package-path packages/Bus` and `--package-path packages/Memory` clean - [x] Local: `pnpm --filter @jarvis/bus test` — 37/37 pass - [x] Local: `bash scripts/check-no-jarvis-bus-world-references.sh` — PASS - [x] Local: `bash scripts/check-bus-protocol-version.sh` — PASS - [x] Local: `bash scripts/check-bus-harness-parity.sh` — PASS - [ ] CI: boundary-gates green (new gate auto-discovered) - [ ] CI: full SPM + webview matrix green ## Non-goals - Doesn't touch PRs #185, #191, #192 - Doesn't refactor `AudioLevelEmitter` (separate concern in PR3) - `bridge.ts` `isJarvisBusShape` guard code is preserved verbatim — only comment changes Closes #19 Closes #45
Sign in to join this conversation.