Seven targeted fixes from the gemini / qwen3 / gemma4 cross-AI reviews of
Phase 8. Risk LOW per all three reviewers; these were ranked as 1.x
candidates rather than ship-blockers, so each is a forward-compatible
extension of an existing surface, not a behavioural change.
1. Corpora/injection/manifest.json — add manifest_version=1; loader
surfaces it via loadFromBundleWithVersion(); jarvis-eval prints
"manifest_version=N" alongside the corpus count so each gate run
records which corpus was exercised. (Gemma4 #3)
2. MCPCrashRunner.swift — inline comments on each FD-whitelist pattern
explaining why it persists across helper restarts (PIPE / FIFO /
systm / KQUEUE / unix / /tmp/jarvis- / -wal / -shm). Future
contributors won't accidentally tighten the whitelist. (Gemma4 #4)
3. DriftReport.swift / DriftClassifier.swift — DriftItem now carries a
`reason` string ("alwaysExcluded membership",
"nondeterministicUnderSampling@temperature=0.7", etc.) so growth of
the exclusion set is visible at every gate run. (Gemma4 #5)
4. .planning/phases/03-hud/checklist.yaml — new P3-09 grep_positive
guard asserting JarvisHUDPanel.swift sets `self.level` to one of
statusBar/mainMenu/screenSaver/popUpMenu (occlusion regression
guard). (Gemini #6)
5. scripts/check-corpus-secrets.sh — extends the D-07 pre-commit hook
to scan .replay / .evaluation / .sqlite session files. Uses
`sqlite3` when available (queries events.tool_* rows directly) and
falls back to plain grep on the binary blob otherwise. (Gemini #7)
6. WakeHysteresisRunner.swift / main.swift — splits the single
"passed" verdict into `pipelineStatus` (ok / notWired) and
`performanceStatus` (pending / pass / warn / fail). Synthetic-only
corpora always report PERFORMANCE: PENDING so an operator never
mistakes a TTS-seed pass for a real-voice pass.
(Gemini + Gemma4 #2)
7. ReplayMCPAdapter.swift — substrate for side-effect-marker
verification. Recorded `tool_result_full` envelopes may now carry
an optional `side_effects: [String]` array; new public APIs
`recordedSideEffects(toolUseId:)` and `sideEffectDelta(toolUseId:
liveMarkers:)` let callers compare live vs recorded markers,
mitigating the byte-equal false-green risk. Helper-side emission
remains a follow-up. (Gemini #1, MEDIUM)
Tests: 63/63 across 9 Harness suites (3 new — manifest version exposure,
sampling-reason carries temperature, synthetic-corpus detection).
Build: clean.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
james.maesandClaude Opus 4.7
5120a27b05