KofTwentyTwo/MarkdownViewr.Windows
2
0 Fork 0
Code Issues 34 Pull Requests 6 Actions Packages Projects Releases 4 Wiki Activity

feat(themes): port document palettes and editable preferences #7

New Issue
Open
opened 2026-10-11 01:22:16 +00:00 by KofTwentyTwo · 6 comments
KofTwentyTwo commented 2026-10-11 01:22:16 +00:00 (Migrated from github.com)
Copy link
Copy source

Complete the original markdownViewr theme behavior from pinned reference 6d08bc9d27d7d7b2c2fa95bb282da330b8cf9021, preserving Darin Kelkhoff's MIT notices. Refs #1 and draft PR #3.

  • Bundle all20 original JSON palettes, verified by Git blob hashes.
  • Validate schema/version, bounded colors/sizes and safe CSS/font embedding.
  • Persist document theme independently from the AppKit shell; retain reading/collapse through theme/reload.
  • Create/edit named custom themes and built-in overrides with copied cancel-safe drafts.
  • Native color/custom-CSS/code-font controls have real invalid/cancel/save/pixel acceptance.
  • Implement all body/heading/code typography, h1–h6 and line height with copied core validation (local worktree).
  • Implement shared global CSS/content width, screen-only styles and independent print layout (local worktree).
  • Implement native theme order/enable/delete/restore, shared catalog/selection and Ctrl+Shift+Up/Down cycling with reading-focus guards (local worktree).
  • Match reference restoration: retain built-in edits as uniquely named custom copies and restore/enable originals (local worktree).
  • Verify full typography actual glyph/save/cancel acceptance in all builds.
  • Verify actual width wrapping/global paint/PDF separation/cancel and sibling appearance updates/local saves in all builds.
  • Verify actual theme submenu order/disable/physical cycle/focus/cancel, sibling deletion/restoration and revised retained-override restoration acceptance.
  • Implement bounded multiple-file JSON import, overwrite/keep-both/skip, newer-schema consent and exact version/metadata-preserving export, including disabled choices (local worktree).
  • Implement native manager New/Copy/Edit/Use selected and cross-dialog copied drafts, including rename conflict validation (local worktree).
  • Verify six real native transfer/conflict/batch/future/disabled-export/draft/cancel cases in all distributed builds.
  • Audit original global/per-theme CSS variables and DOM selectors for full stylesheet compatibility.
  • Complete corresponding security/native/published/installed acceptance and maintainer review.

Measured pushed baseline bf4fcdc / CI38128311242:54 native/published and53 installed stable/dev tests, zero failures/skips. Basic theme choice/edit/cancel/paint and the previous restoration behavior pass there. The new reference-compatible restoration deliberately strengthens that case to require preserved custom JSON/paint and explicit selection of the original.

Current local 517 core tests/100% measured lines, zero-warning full solution build, format and four-doc lint pass. Focused regressions:32 extensions,18 typography,22 appearance,23 list management and46 transfer. Latest coverage: artifacts/theme-transfer-core.69 UI cases are discovered headlessly; twelve new runtime cases and the strengthened restoration case compile but have not run. Full target69 native/published and68 per installed channel.

Pushed head stays 1cfc07f. Current pushed window CI remains red (54/57 native; published timeout). Four original window corrections are validated/staged, separate from all new unstaged/uncommitted renderer/theme work. Required signed/DCO commits await 1Password authentication after two signer failures; no new commit/push/hosted proof exists. Keep this issue open. No production signing/release, merge or fabricated human review. Substantial assistance: Codex (GPT-6).

Local theme transfer is implemented against the pinned reference settings: owned multiple-file JSON import; independent invalid/oversized-file rejection; exact overwrite/keep-both/skip conflicts; explicit newer-schema confirmation; metadata/version-preserving export of disabled choices. Serial reads are bounded before parsing. Strict version-one parsing remains; compatible parsing validates every known field and newer imports cannot be persisted without approval. Native manager New/Copy/Edit/Use selected and import/export keep one copied draft across successive dialogs, stop on owner closure and commit only with Save themes. Renamed editor collisions stay open instead of silently overwriting another palette.

517 core tests/100% measured line coverage,46 new focused transfer cases, zero-warning full build, format/four-doc lint pass. Latest coverage: artifacts/theme-transfer-core. Headless discovery actually finds 69 UI cases; artifacts/theme-transfer-ui-discovery.log. Six new real picker/conflict/batch/future/disabled-export/draft/cancel cases compile but have not run. Combined runtime target69 native/published and68 per installed channel; original staged correction alone remains57/56. No current-head desktop/PDF/signature proof.

Pushed head remains1cfc07f. Original four validated corrections are staged unchanged; all renderer/theme/transfer work is unstaged/uncommitted while 1Password authentication is pending. No unsigned commit/push or Azure/merge/tag/release. Original CSS-variable/DOM-selector compatibility, raw-HTML/source-heading/link/render fidelity, Windows activation, standards/reviews and exact signed artifacts remain required.

Complete the original markdownViewr theme behavior from pinned reference `6d08bc9d27d7d7b2c2fa95bb282da330b8cf9021`, preserving Darin Kelkhoff's MIT notices. Refs #1 and draft PR #3. - [x] Bundle all20 original JSON palettes, verified by Git blob hashes. - [x] Validate schema/version, bounded colors/sizes and safe CSS/font embedding. - [x] Persist document theme independently from the AppKit shell; retain reading/collapse through theme/reload. - [x] Create/edit named custom themes and built-in overrides with copied cancel-safe drafts. - [x] Native color/custom-CSS/code-font controls have real invalid/cancel/save/pixel acceptance. - [x] Implement all body/heading/code typography, h1–h6 and line height with copied core validation (local worktree). - [x] Implement shared global CSS/content width, screen-only styles and independent print layout (local worktree). - [x] Implement native theme order/enable/delete/restore, shared catalog/selection and Ctrl+Shift+Up/Down cycling with reading-focus guards (local worktree). - [x] Match reference restoration: retain built-in edits as uniquely named custom copies and restore/enable originals (local worktree). - [ ] Verify full typography actual glyph/save/cancel acceptance in all builds. - [ ] Verify actual width wrapping/global paint/PDF separation/cancel and sibling appearance updates/local saves in all builds. - [ ] Verify actual theme submenu order/disable/physical cycle/focus/cancel, sibling deletion/restoration and revised retained-override restoration acceptance. - [x] Implement bounded multiple-file JSON import, overwrite/keep-both/skip, newer-schema consent and exact version/metadata-preserving export, including disabled choices (local worktree). - [x] Implement native manager New/Copy/Edit/Use selected and cross-dialog copied drafts, including rename conflict validation (local worktree). - [ ] Verify six real native transfer/conflict/batch/future/disabled-export/draft/cancel cases in all distributed builds. - [ ] Audit original global/per-theme CSS variables and DOM selectors for full stylesheet compatibility. - [ ] Complete corresponding security/native/published/installed acceptance and maintainer review. Measured pushed baseline `bf4fcdc` / CI38128311242:54 native/published and53 installed stable/dev tests, zero failures/skips. Basic theme choice/edit/cancel/paint and the previous restoration behavior pass there. The new reference-compatible restoration deliberately strengthens that case to require preserved custom JSON/paint and explicit selection of the original. Current local **517 core tests/100% measured lines**, zero-warning full solution build, format and four-doc lint pass. Focused regressions:32 extensions,18 typography,22 appearance,23 list management and46 transfer. Latest coverage: `artifacts/theme-transfer-core`.69 UI cases are discovered headlessly; twelve new runtime cases and the strengthened restoration case compile but have not run. Full target69 native/published and68 per installed channel. Pushed head stays `1cfc07f`. Current pushed window CI remains red (54/57 native; published timeout). Four original window corrections are validated/staged, separate from all new unstaged/uncommitted renderer/theme work. Required signed/DCO commits await 1Password authentication after two signer failures; no new commit/push/hosted proof exists. Keep this issue open. No production signing/release, merge or fabricated human review. Substantial assistance: Codex (GPT-6). Local theme transfer is implemented against the [pinned reference settings](https://github.com/darinkelkhoff/markdownViewr/blob/6d08bc9d27d7d7b2c2fa95bb282da330b8cf9021/markdownViewr/SettingsView.swift): owned multiple-file JSON import; independent invalid/oversized-file rejection; exact overwrite/keep-both/skip conflicts; explicit newer-schema confirmation; metadata/version-preserving export of disabled choices. Serial reads are bounded before parsing. Strict version-one parsing remains; compatible parsing validates every known field and newer imports cannot be persisted without approval. Native manager New/Copy/Edit/Use selected and import/export keep one copied draft across successive dialogs, stop on owner closure and commit only with Save themes. Renamed editor collisions stay open instead of silently overwriting another palette. **517 core tests/100% measured line coverage**,46 new focused transfer cases, zero-warning full build, format/four-doc lint pass. Latest coverage: `artifacts/theme-transfer-core`. Headless discovery actually finds **69 UI cases**; `artifacts/theme-transfer-ui-discovery.log`. Six new real picker/conflict/batch/future/disabled-export/draft/cancel cases compile but have **not run**. Combined runtime target69 native/published and68 per installed channel; original staged correction alone remains57/56. No current-head desktop/PDF/signature proof. Pushed head remains1cfc07f. Original four validated corrections are staged unchanged; all renderer/theme/transfer work is unstaged/uncommitted while 1Password authentication is pending. No unsigned commit/push or Azure/merge/tag/release. Original CSS-variable/DOM-selector compatibility, raw-HTML/source-heading/link/render fidelity, Windows activation, standards/reviews and exact signed artifacts remain required.
KofTwentyTwo commented 2026-10-11 01:30:25 +00:00 (Migrated from github.com)
Copy link
Copy source

Signed/DCO theme milestone 0507ca5 and working-area fix fa0df78 are pushed to draft PR #3. All 20 pinned original JSON palettes are embedded unchanged and their full MIT notice ships with the app. Document palette selection persists independently of the shell theme and retains the viewport. Local build is zero-warning; 117 core tests/100% coverage, formatting and docs/hooks pass.

Hosted acceptance is running on exact head fa0df78 (CI 38101906688). The theme test now checks saved selection and retained content; a follow-up strengthens this to actual painted colors and a retained fixture screenshot. User-theme editing/custom CSS/font controls remain open in this issue. No release or signing claim.

Signed/DCO theme milestone 0507ca5 and working-area fix fa0df78 are pushed to draft PR #3. All 20 pinned original JSON palettes are embedded unchanged and their full MIT notice ships with the app. Document palette selection persists independently of the shell theme and retains the viewport. Local build is zero-warning; 117 core tests/100% coverage, formatting and docs/hooks pass. Hosted acceptance is running on exact head fa0df78 (CI 38101906688). The theme test now checks saved selection and retained content; a follow-up strengthens this to actual painted colors and a retained fixture screenshot. User-theme editing/custom CSS/font controls remain open in this issue. No release or signing claim.
KofTwentyTwo commented 2026-10-11 01:34:46 +00:00 (Migrated from github.com)
Copy link
Copy source

Fitted head fa0df78 completed with 25/26 UI tests passed; its document-theme choice passed. The retained screenshot now clearly shows the status line inside the window, so clipping was corrected but did not resolve the automation lookup. A diagnostic property read also threw on the browser peer's unsupported IsOffscreen property; it now uses ValueOrDefault.

Signed/pushed 77dd04d declares the native status peer before the embedded browser, without changing Grid.Row or the visual layout. Original initial/missing-status/recovery assertions remain intact. Theme acceptance now also waits for actual painted Catppuccin-dark and GitHub-Light backgrounds and retains a fixture screenshot. Exact current CI 38102249889 is running; CodeQL 38102249846, security 38102249838 and scripts 38102249407 are also the handles to follow. No failed run was restarted.

Fitted head fa0df78 completed with 25/26 UI tests passed; its document-theme choice passed. The retained screenshot now clearly shows the status line inside the window, so clipping was corrected but did not resolve the automation lookup. A diagnostic property read also threw on the browser peer's unsupported IsOffscreen property; it now uses ValueOrDefault. Signed/pushed 77dd04d declares the native status peer before the embedded browser, without changing Grid.Row or the visual layout. Original initial/missing-status/recovery assertions remain intact. Theme acceptance now also waits for actual painted Catppuccin-dark and GitHub-Light backgrounds and retains a fixture screenshot. Exact current CI 38102249889 is running; CodeQL 38102249846, security 38102249838 and scripts 38102249407 are also the handles to follow. No failed run was restarted.
KofTwentyTwo commented 2026-10-11 02:15:15 +00:00 (Migrated from github.com)
Copy link
Copy source

Editable-theme milestone 30ca0943c0 passed CI 38102867556 completely: 29 native/UI tests, published/installed channels, build/coverage/format, CodeQL/security/scripts. Tests check actual painted CSS colors, native color/code-font/CSS edits, invalid input plus cancellation, and confirmed built-in restoration. Original 20 JSON assets and MIT notice remain intact.

The follow-up native NumberBox edit to size 17 also passes in both recent 29/30 UI runs; their separate failure is frontmatter #8. A full reference audit for theme import/export/delete, enabled/order choices and additional body/heading font preferences remains part of #1. Do not infer the whole port is finished from this milestone.

Editable-theme milestone 30ca0943c09a8662794c2d400f1b5c49de426942 passed [CI 38102867556](https://github.com/KofTwentyTwo/MarkdownViewr.Windows/actions/runs/38102867556) completely: 29 native/UI tests, published/installed channels, build/coverage/format, CodeQL/security/scripts. Tests check actual painted CSS colors, native color/code-font/CSS edits, invalid input plus cancellation, and confirmed built-in restoration. Original 20 JSON assets and MIT notice remain intact. The follow-up native NumberBox edit to size 17 also passes in both recent 29/30 UI runs; their separate failure is frontmatter #8. A full reference audit for theme import/export/delete, enabled/order choices and additional body/heading font preferences remains part of #1. Do not infer the whole port is finished from this milestone.
KofTwentyTwo commented 2026-10-12 00:13:35 +00:00 (Migrated from github.com)
Copy link
Copy source

Signed/DCO head1bfab22 is pushed after exactb2ecc8c CI38185403701 became terminal. It includes24a464e effective default-viewer status and1bfab22 native theme palette/state/default controls plus fixture cleanup. General reports the actual effective .md selection with bounded read-only Windows ProgID querying, exact installed/edition ownership and manual/activation refresh. Seven actual non-GUI API/isolated registry tests pass.

Theme rows show five validated color previews with hexadecimal accessible names/tooltips and textual Built-in/edited/Custom, Enabled/Disabled and Default labels. Native default radio selection enables the selected choice inside the copied draft; Save applies the existing saved DocumentTheme to open/new readers, Cancel discards it. Existing edit/copy/import/restore behaviors remain. The new actual native case checks painted Nord swatch pixels, default/enabled states, save/reopen and retains a Settings screenshot.106 native cases compile/discover; zero-warning Release build, format and hooks pass. Core unchanged598/100% measured lines.

Previousb2ecc8c focused23/24 and native101/102 fail, zero skips, only source physical alignment. Both Printing cases/raw-inline folds/picker/Contents options pass in completed suites. Published process reaches unchanged600seconds without final TRX; its process log records alignment failure and ten failed exits. No installed lifecycle outcome. Exact pinned FlaUI source uses CloseMainWindow plus5-second wait; fixture teardown now closes every owned PID window before the unchanged close/kill fallback. No cases/assertions/deadlines removed or expanded. Retain current-native/current-installed-b2ecc8c logs and actual artifact bundle38185403701.

Fresh exact1bfab22 CI38187115859 is live; pr-gates/security pass, scripts/CodeQL live. Actual default/status/palette/trim-only tooltip and full published/installed runtime remain pending. Owner design acceptance, actual Windows chooser/Explorer, shared/license and genuine head review, deployed Azure profile/identity and shipped signature trust remain required. No local GUI input, preview55472 changes, Azure retry, shared merge, tag or production publication.

Signed/DCO head1bfab22 is pushed after exactb2ecc8c CI38185403701 became terminal. It includes24a464e effective default-viewer status and1bfab22 native theme palette/state/default controls plus fixture cleanup. General reports the actual effective .md selection with bounded read-only Windows ProgID querying, exact installed/edition ownership and manual/activation refresh. Seven actual non-GUI API/isolated registry tests pass. Theme rows show five validated color previews with hexadecimal accessible names/tooltips and textual Built-in/edited/Custom, Enabled/Disabled and Default labels. Native default radio selection enables the selected choice inside the copied draft; Save applies the existing saved DocumentTheme to open/new readers, Cancel discards it. Existing edit/copy/import/restore behaviors remain. The new actual native case checks painted Nord swatch pixels, default/enabled states, save/reopen and retains a Settings screenshot.106 native cases compile/discover; zero-warning Release build, format and hooks pass. Core unchanged598/100% measured lines. Previousb2ecc8c focused23/24 and native101/102 fail, zero skips, only source physical alignment. Both Printing cases/raw-inline folds/picker/Contents options pass in completed suites. Published process reaches unchanged600seconds without final TRX; its process log records alignment failure and ten failed exits. No installed lifecycle outcome. Exact pinned FlaUI source uses CloseMainWindow plus5-second wait; fixture teardown now closes every owned PID window before the unchanged close/kill fallback. No cases/assertions/deadlines removed or expanded. Retain current-native/current-installed-b2ecc8c logs and actual artifact bundle38185403701. Fresh exact1bfab22 CI38187115859 is live; pr-gates/security pass, scripts/CodeQL live. Actual default/status/palette/trim-only tooltip and full published/installed runtime remain pending. Owner design acceptance, actual Windows chooser/Explorer, shared/license and genuine head review, deployed Azure profile/identity and shipped signature trust remain required. No local GUI input, preview55472 changes, Azure retry, shared merge, tag or production publication.
KofTwentyTwo commented 2026-10-12 00:24:44 +00:00 (Migrated from github.com)
Copy link
Copy source

Exact pushed1bfab22 / CI38187115859 focused23/26 fails, zero skips. The new palette/default case cannot find ThemeChoice:Nord; existing future-schema/export case cannot find ThemeChoice:Owned future. The taller native rows leave these choices virtualized offscreen. Signed/DCO localb1f8af7 scrolls the owned ThemeList through its native Scroll pattern until the same exact automation ID is realized, then uses the same native selection. All value assertions/cases and10-second deadline remain; Release/format/hooks pass. Fresh runtime is required.

The long-title tooltip/physical heading test passes, as do both Printing cases, raw-inline folding, picker cancellation and Contents options. Physical source/reader alignment still fails on1bfab22; signed local49f0556 restores the trusted heading Tag on the Contents content Grid for repeat ItemClick. Client pointer diagnostics were not screen-space coordinates; the earlier tooltip-interception inference was not established. Retain current-focused-1bfab22.log and actual focused TRX/artifacts38187115859.

Full native114611732252 and installed114611732224 remain live; local49f0556/b1f8af7 are held until terminal. No installed/signature outcome inferred and no checks/assertions/deadlines changed. Reference ContentView/SettingsView/ThemeManager cached text matches the immutable6d08bc9 blobs after newline/BOM normalization. No local input, owner preview change, Azure retry, shared merge, tag or publication.

Exact pushed1bfab22 / CI38187115859 focused23/26 fails, zero skips. The new palette/default case cannot find ThemeChoice:Nord; existing future-schema/export case cannot find ThemeChoice:Owned future. The taller native rows leave these choices virtualized offscreen. Signed/DCO localb1f8af7 scrolls the owned ThemeList through its native Scroll pattern until the same exact automation ID is realized, then uses the same native selection. All value assertions/cases and10-second deadline remain; Release/format/hooks pass. Fresh runtime is required. The long-title tooltip/physical heading test passes, as do both Printing cases, raw-inline folding, picker cancellation and Contents options. Physical source/reader alignment still fails on1bfab22; signed local49f0556 restores the trusted heading Tag on the Contents content Grid for repeat ItemClick. Client pointer diagnostics were not screen-space coordinates; the earlier tooltip-interception inference was not established. Retain current-focused-1bfab22.log and actual focused TRX/artifacts38187115859. Full native114611732252 and installed114611732224 remain live; local49f0556/b1f8af7 are held until terminal. No installed/signature outcome inferred and no checks/assertions/deadlines changed. Reference ContentView/SettingsView/ThemeManager cached text matches the immutable6d08bc9 blobs after newline/BOM normalization. No local input, owner preview change, Azure retry, shared merge, tag or publication.
KofTwentyTwo commented 2026-10-12 03:52:03 +00:00 (Migrated from github.com)
Copy link
Copy source

Signed/DCO3b01199, now pushed in82256f3, corrects theme-export filename suggestions for Windows reserved COM¹/COM²/COM³ and LPT¹/LPT²/LPT³ device names. Six focused theory cases verify the existing safe prefix;668 core tests pass with100% measured core line coverage, formatting and hooks pass. No theme-schema or saved-default semantics changed. Fresh hosted gates are CI38201379210; previous actual native palette/default/transfer and distributed acceptance is retained, not inferred for the new head.

Substantial AI assistance: Codex.

Signed/DCO3b01199, now pushed in82256f3, corrects theme-export filename suggestions for Windows reserved COM¹/COM²/COM³ and LPT¹/LPT²/LPT³ device names. Six focused theory cases verify the existing safe prefix;668 core tests pass with100% measured core line coverage, formatting and hooks pass. No theme-schema or saved-default semantics changed. Fresh hosted gates are [CI38201379210](https://github.com/KofTwentyTwo/MarkdownViewr.Windows/actions/runs/38201379210); previous actual native palette/default/transfer and distributed acceptance is retained, not inferred for the new head. Substantial AI assistance: Codex.
Sign in to join this conversation.
No Branch/Tag Specified
Labels
Clear labels
accessibility
Barrier affecting people with disabilities
 bug
Something isn't working
 deferred
Explicitly deferred work
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 javascript
Pull requests that update javascript code
 quality
Testing, reliability, and maintainability
 question
Further information is requested
 refactor
Internal changes without intended behavior changes
 release
Packaging, signing, and release delivery
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/MarkdownViewr.Windows#7