fix: push supplemental images on release builds again (0.3.5 regression) #35

Merged

KofTwentyTwo merged 1 commits from feature/supplemental-push-boolean into develop

2026-10-13 22:11:48 +00:00

Author	SHA1	Message	Date
james.maesandClaude Opus 5.5	69898922be	fix: push supplemental images on release builds again CircleCI renders the boolean push parameter as 1/0 in the step environment, but build_push_supplemental.sh only pushed when PUSH_IMAGES was the string "true". Since 0.3.5 every release build built and scanned supplemental images and never pushed them, so deployments referencing them hit ImagePullBackOff (kof22 0.1.75). PUSH_IMAGES now accepts true/1/yes/on and false/0/no/off/empty; unset still means push, and an unrecognised value fails before any build. Tests cover release-mode pushes (1, true, TRUE) of every supplemental image, PR-mode non-pushes (0, false, empty), and the invalid value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Maes <james@kof22.com>	2026-10-13 17:05:34 -05:00

Author

SHA1

Message

Date

james.maesandClaude Opus 5.5

69898922be

fix: push supplemental images on release builds again

CircleCI renders the boolean push parameter as 1/0 in the step
environment, but build_push_supplemental.sh only pushed when
PUSH_IMAGES was the string "true". Since 0.3.5 every release build
built and scanned supplemental images and never pushed them, so
deployments referencing them hit ImagePullBackOff (kof22 0.1.75).

PUSH_IMAGES now accepts true/1/yes/on and false/0/no/off/empty; unset
still means push, and an unrecognised value fails before any build.
Tests cover release-mode pushes (1, true, TRUE) of every supplemental
image, PR-mode non-pushes (0, false, empty), and the invalid value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

2026-10-13 17:05:34 -05:00