fix(wizard): an empty token box asks for a token instead of showing a raw error #173

Merged
james.maes merged 1 commits from fix/172-wizard-empty-token into main 2026-11-11 02:03:09 +00:00
Owner

What

Step 2 of Add account with nothing typed says "Enter a token to continue." and does not call the server.

Why

Closes #172

The wizard showed the engine's raw argument error and logged "token rejected" for a token that was never sent.

How it was tested

  • TryAdvance_WithNoTokenTyped_AsksForOne_AndAsksNothingOfTheServer (empty and blank): stays on step 2, the message, no lister call.
  • Gates: build, 1,074 engine and 212 CLI tests, 100% line coverage, format, UI suite 13 of 13.

Checklist

  • Commits are signed and signed off (git commit -S -s)
  • Zero build warnings; format and lint are clean
  • Tests added or updated; the 100% coverage gate still passes
  • Docs updated for user-visible changes; threat model updated if the attack surface changed (neither applies)
  • No secrets, credentials, or personal data
  • New dependencies are justified below, or none were added (none)
  • Substantial AI assistance, if any, is noted here (written with Claude Code)

🤖 Generated with Claude Code

## What Step 2 of Add account with nothing typed says "Enter a token to continue." and does not call the server. ## Why Closes #172 The wizard showed the engine's raw argument error and logged "token rejected" for a token that was never sent. ## How it was tested - `TryAdvance_WithNoTokenTyped_AsksForOne_AndAsksNothingOfTheServer` (empty and blank): stays on step 2, the message, no lister call. - Gates: build, 1,074 engine and 212 CLI tests, 100% line coverage, format, UI suite 13 of 13. ## Checklist - [x] Commits are signed and signed off (`git commit -S -s`) - [x] Zero build warnings; format and lint are clean - [x] Tests added or updated; the 100% coverage gate still passes - [x] Docs updated for user-visible changes; threat model updated if the attack surface changed (neither applies) - [x] No secrets, credentials, or personal data - [x] New dependencies are justified below, or none were added (none) - [x] Substantial AI assistance, if any, is noted here (written with Claude Code) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
james.maes added 1 commit 2026-11-11 02:02:52 +00:00
Step 2 of Add account sent an empty token to the lister, whose argument check
answered with "The value cannot be an empty string...", and the log said the
token was rejected although none was sent. The wizard now says "Enter a token
to continue." and asks nothing of the server.

Closes #172

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
james.maes merged commit 80eeb81edd into main 2026-11-11 02:03:09 +00:00
Sign in to join this conversation.