"A Gitea server" stood beside a bare "GitHub": an article and the word
server on one side only. The two options are now named alike; the server
address box that appears under Gitea says the rest. README sentence and
picture follow.
Refs #206
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
From the review of #207.
- Step 2 named the host alone, and the normalized address was visible only
after going back: two servers on one host read the same. The note of step
2 now gives the address in full, as it was normalized.
- The place was taken before its lister: had the lister of the new place
failed to be made, the wizard would have been on the new place with the
lister and the token of the old one. The lister is made first.
- While step 2 checks a token, Next and Back do nothing: the answer that is
on its way is the answer for the place and the token the wizard still
holds. The dialog already held its buttons; the view model now holds too.
- An edit no longer puts the stored address into the (hidden) address box.
- The message about the server goes away when the address is corrected.
- An account's page heads its token box with what the forge calls a token.
- Tests state what was missing: what step 2 is told when the place changes,
that the account is saved at the place step 1 accepted whatever the choice
is set to afterwards, the two rules above. 11 single-rule mutations of the
change: all caught.
- ADR 0010 and T16 corrected; the README's picture of the wizard shows the
choice.
Refs #206
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
Step 3 of Gitea support (#201): the desktop app adds, loads and syncs an
account on a Gitea server.
- Step 1 of the wizard asks, for a new account, where the repositories are:
GitHub (the default) or a Gitea server and its address. The address is
checked by the rule the command line uses and shown as it was normalized,
which is the address the token goes to.
- The wizard holds the lister of one place at a time. The shell gives it a
lister per place, step 1 takes the one of the chosen place, and step 2 has
no other to send the token to. A wizard that was given one lister (an edit,
a Quick Sync connection saved as an account) offers no choice and says
where the account is.
- What was entered for one place is not carried to another: when step 1 is
left with another place than before, the typed token, the organization and
the organization list are emptied. The default token is a GitHub token and
is neither offered nor preselected for a Gitea server.
- Texts that named GitHub follow the place: the token box, the page a token
is made on, the note of step 2, and the connect card of an account's page.
- The offline UI fixture answers for a Gitea server with an organization of
its own, and the UI suite walks the wizard for one. The wizard's listers
are wrapped by the fixture like a workspace's.
- README, ADR 0010, threat model T16.
Closes#206
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
james.maesandClaude Fable 5.2