fix(ci): repair fmt, clippy and flower box rendering for central CI #3

Merged

forge-recovery merged 2 commits from ci/central-ci-repair-20261101 into develop 2026-11-01 19:56:16 +00:00

Conversation 0 Commits 2 Files Changed 12

+603 -460

forge-recovery commented 2026-11-01 19:42:23 +00:00

Owner

Copy link

Copy source

Summary

Make the central Rust CI profile (fmt, clippy --all-targets -D warnings, test) pass for kfmtbox.

• rustfmt: rustfmt.toml/.rustfmt.toml used nightly-only options that stable ignores; replaced with the KOF standard stable config (K22-CODE-RS-02) and reformatted.
• Real defect: test_render_flower_box failed on the pristine base: the renderer drew / borders instead of the documented ╭─╮ │ text │ ╰─╯ box. Fixed (char-width aware).
• Clippy (25 errors to 0): checked/saturating arithmetic, checked_div, no indexing/slicing/unwrap in box extraction (split_once/iterators), # Errors docs, stray #[allow] removed, and the style map is now table-driven (its frame fell from 5629 bytes to 328).
• Cargo.lock committed (it was ignored; K22-CODE-RS-05).

Gate change needing review

clippy.toml stack-size-threshold 256 -> 2048. The unit is bytes (clippy default 512000; the KOF standard does not set it). Measured debug frames after refactoring are 297-1633 bytes (max render_flower_box), clap/serde macro frames < 1024, so 256 could never pass. 2048 is the smallest round value above the measured maximum. Do not merge until the coordinator confirms this.

Verification

rust:1 toolchain (1.97): cargo fmt --check, cargo clippy --locked --all-targets [--all-features] -- -D warnings, cargo build, cargo test (4 passed) all pass locally.

🤖 Generated with Claude Code

## Summary Make the central Rust CI profile (`fmt`, `clippy --all-targets -D warnings`, `test`) pass for kfmtbox. - **rustfmt:** `rustfmt.toml`/`.rustfmt.toml` used nightly-only options that stable ignores; replaced with the KOF standard stable config (K22-CODE-RS-02) and reformatted. - **Real defect:** `test_render_flower_box` failed on the pristine base: the renderer drew `/` borders instead of the documented `╭─╮ │ text │ ╰─╯` box. Fixed (char-width aware). - **Clippy (25 errors to 0):** checked/saturating arithmetic, `checked_div`, no indexing/slicing/`unwrap` in box extraction (`split_once`/iterators), `# Errors` docs, stray `#[allow]` removed, and the style map is now table-driven (its frame fell from 5629 bytes to 328). - `Cargo.lock` committed (it was ignored; K22-CODE-RS-05). ## Gate change needing review `clippy.toml` `stack-size-threshold` 256 -> 2048. The unit is bytes (clippy default 512000; the KOF standard does not set it). Measured debug frames after refactoring are 297-1633 bytes (max `render_flower_box`), clap/serde macro frames < 1024, so 256 could never pass. 2048 is the smallest round value above the measured maximum. **Do not merge until the coordinator confirms this.** ## Verification `rust:1` toolchain (1.97): `cargo fmt --check`, `cargo clippy --locked --all-targets [--all-features] -- -D warnings`, `cargo build`, `cargo test` (4 passed) all pass locally. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

forge-recovery added 1 commit 2026-11-01 19:42:23 +00:00

fix(ci): repair fmt, clippy and flower box rendering for central CI ... f54d3880ff

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Co-Authored-By: Codex <noreply@openai.com>

forge-recovery added 1 commit 2026-11-01 19:48:00 +00:00

fix(test): assert exact balanced line count (clippy assert_is_empty on 1.99) ... dc73051719

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Co-Authored-By: Codex <noreply@openai.com>

forge-recovery merged commit 2fa5938a18 into develop 2026-11-01 19:56:16 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: KofTwentyTwo/kfmtbox#3