QRun-IO/qbit-alerts
3
0 Fork 0
Code Issues 2 Pull Requests 5 Actions Packages Projects Releases 18 Wiki Activity

fix(config): never serialize the alerts runtime (child lists failed to render) #34

Merged
KofTwentyTwo merged 1 commits from feature/recipients-widget-json into develop 2026-10-14 21:10:02 +00:00
Conversation 0 Commits 1 Files Changed 3
+137 -1
KofTwentyTwo commented 2026-10-14 20:54:44 +00:00 (Migrated from github.com)
Copy link
Copy source

Problem

On kof22 (admin.kof22.com, qbit-alerts 0.1.0-RC.2 on QQQ 4.1.0-RC.6), opening a notification's Recipients tab showed:

An error occurred loading widget content. IllegalArgumentException (Error in JSON Serialization)

The server log showed JsonUtils: Error serializing object of type [ChildRecordListData] with the cause StreamConstraintsException: Document nesting depth (1001) exceeds the maximum allowed (1000).

Root cause

ChildRecordListData carries the child table's QTableMetaData. That class implements core SourceQBitAware, and the interface's default getSourceQBitConfig() acts as a bean getter, so Jackson serializes the qbit config. AlertsQBitConfig.getRuntime() returns the AlertsRuntime, and the runtime's config points back at the config:

QTableMetaData.sourceQBitConfig -> AlertsQBitConfig.runtime -> AlertsRuntime.config -> AlertsQBitConfig.runtime -> ...

The transient modifier doesn't stop Jackson, because it serializes through getters. Every alerts child list hits this, not just Recipients: Timeline, Records, Members and the others all fail the same way.

Fix

  • AlertsQBitConfig.getRuntime() and getAudienceResolver() are now @JsonIgnore. This is the pattern the cms, quick-search and sql-workbench configs already use.

  • New ChildListWidgetsJsonTest:

    • It renders the Recipients list for a notification with two recipient rows and serializes it.
    • It renders every child-list widget in the qbit and serializes each one.
    • It serializes the config itself.

    All three tests fail without the fix and pass with it.

  • CHANGELOG entry.

The core side is a separate QRun-IO/qqq PR. It stops SourceQBitAware from serializing qbit configs at all, and it makes JsonUtils name the reference cycle instead of failing at 1000 levels deep. This qbit fix lets kof22 work on the QQQ 4.1.0-RC.6 it runs today.

Verification

./mvnw -B verify passes, with 176 tests, 0 failures, and checkstyle, guardrails and JaCoCo all green.

Release

kof22 needs a qbit-alerts RC with this fix. It is pinned to RC.2, and Website-Backend#227 moves it to RC.5.

🤖 Generated with Claude Code

## Problem On kof22 (admin.kof22.com, qbit-alerts 0.1.0-RC.2 on QQQ 4.1.0-RC.6), opening a notification's **Recipients** tab showed: > An error occurred loading widget content. IllegalArgumentException (Error in JSON Serialization) The server log showed `JsonUtils: Error serializing object of type [ChildRecordListData]` with the cause `StreamConstraintsException: Document nesting depth (1001) exceeds the maximum allowed (1000)`. ## Root cause `ChildRecordListData` carries the child table's `QTableMetaData`. That class implements core `SourceQBitAware`, and the interface's default `getSourceQBitConfig()` acts as a bean getter, so Jackson serializes the qbit config. `AlertsQBitConfig.getRuntime()` returns the `AlertsRuntime`, and the runtime's `config` points back at the config: `QTableMetaData.sourceQBitConfig -> AlertsQBitConfig.runtime -> AlertsRuntime.config -> AlertsQBitConfig.runtime -> ...` The `transient` modifier doesn't stop Jackson, because it serializes through getters. Every alerts child list hits this, not just Recipients: Timeline, Records, Members and the others all fail the same way. ## Fix - `AlertsQBitConfig.getRuntime()` and `getAudienceResolver()` are now `@JsonIgnore`. This is the pattern the cms, quick-search and sql-workbench configs already use. - New `ChildListWidgetsJsonTest`: - It renders the Recipients list for a notification with two recipient rows and serializes it. - It renders every child-list widget in the qbit and serializes each one. - It serializes the config itself. All three tests fail without the fix and pass with it. - CHANGELOG entry. The core side is a separate QRun-IO/qqq PR. It stops `SourceQBitAware` from serializing qbit configs at all, and it makes JsonUtils name the reference cycle instead of failing at 1000 levels deep. This qbit fix lets kof22 work on the QQQ 4.1.0-RC.6 it runs today. ## Verification `./mvnw -B verify` passes, with 176 tests, 0 failures, and checkstyle, guardrails and JaCoCo all green. ## Release kof22 needs a qbit-alerts RC with this fix. It is pinned to RC.2, and Website-Backend#227 moves it to RC.5. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
Architecture review: coupling, cohesion, UI API
 bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 java
Pull requests that update java code
 question
Further information is requested
 release:rc
Merging this develop PR cuts the next release candidate
 secuurity
ux
Admin UX / information architecture
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qbit-alerts#34