Compare commits

...
Author SHA1 Message Date
james.maesandClaude Opus 5.5 9fc0eed499 fix(runtime): shutdown hook holds the runtime weakly
Every AssistantRuntime registered a JVM shutdown hook that held the
runtime, and so its whole QInstance, until JVM exit. A host test suite
that builds an instance per test leaked every instance (kof22's suite ran
out of heap). The hook now holds a weak reference.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-15 15:53:47 -05:00
james.maes 23779790ab Merge pull request #55 from QRun-IO/fix/help-bundle-version
fix(help): help bundle version comes from the build, not a hardcoded SNAPSHOT
2026-10-14 22:37:20 -05:00
james.maesandClaude Opus 5.5 079e8d39e2 fix(help): the help bundle carries the artifact version (Maven-filtered) instead of a hardcoded SNAPSHOT
On release branches the bundle's version and the producer's differed, so the
bundle test that asserts they match failed, and released bundles recorded
SNAPSHOT as their provenance. help/*.yaml is now filtered:
version: ${project.version}.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-14 22:03:49 -05:00
3 changed files with 16 additions and 2 deletions

No files matched your search

+2
View File
@@ -114,6 +114,7 @@
<directory>src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>help/*.yaml</include>
<include>qbit-assistant.properties</include>
</includes>
</resource>
@@ -121,6 +122,7 @@
<directory>src/main/resources</directory>
<filtering>false</filtering>
<excludes>
<exclude>help/*.yaml</exclude>
<exclude>qbit-assistant.properties</exclude>
</excludes>
</resource>
@@ -17,6 +17,7 @@
package com.kingsrook.qbits.assistant;
import java.lang.ref.WeakReference;
import java.net.InetAddress;
import java.time.Clock;
import java.time.Duration;
@@ -178,11 +179,22 @@ public class AssistantRuntime
this.contextBuilder = new ContextBuilder(config, kernel, toolbox).withKnowledgeTool(knowledgeTool).withBulkLoadTools(bulkLoadTools);
if(Boolean.TRUE.equals(config.getRegisterShutdownHook()))
{
///////////////////////////////////////////////////////////////////////
// the hook holds the runtime weakly: a runtime (and its QInstance) //
// that is dropped without shutdown() - every test that builds an //
// instance - must not stay reachable from the JVM's hooks //
///////////////////////////////////////////////////////////////////////
WeakReference<AssistantRuntime> self = new WeakReference<>(this);
Integer graceSeconds = config.getShutdownGraceSeconds();
shutdownHook = new Thread(() ->
{
try
{
shutdown(Duration.ofSeconds(config.getShutdownGraceSeconds()));
AssistantRuntime runtime = self.get();
if(runtime != null)
{
runtime.shutdown(Duration.ofSeconds(graceSeconds));
}
}
catch(Throwable ignored)
{
@@ -1,5 +1,5 @@
bundle: qbit-assistant
version: 0.1.0-SNAPSHOT
version: ${project.version}
layer: QBIT
entries:
- key: app:assistantAdmin;slot:help