Every tool is registered once in tools.registry.ToolRegistry: its name, its
kind (READ, PROPOSE, DISPLAY), the checks it runs, its definition and how one
call of it runs. The chat's tool list, a tool call of a turn and a confirmed
write all look a tool up there; the turn engine and the confirm route no
longer choose a tool family with an if-chain.
"Run one tool call for this person under this policy, and log it" moves
out of TurnEngine into engine.ToolCallService, which the confirm route uses
too: the refusal of a tool that is not offered, the call (with the person's
own session) and the assistant_tool_call row.
What moved where:
- ContextBuilder.tools: the per-family blocks become
ToolRegistry.definitions(ToolOffer); each family's block is its
AssistantTool.definition (UiApiToolFamily, engine.KernelToolFamily,
KnowledgeToolFamily, PresentResultsToolFamily, BulkLoadToolFamily).
isStrict moves to ToolRegistry.isStrict.
- TurnEngine.executeTools: the 'Unknown tool' refusal is
ToolCallService.refusal; the dispatch is ToolCallService.execute; each
branch is its family's AssistantTool.execute (the data families keep the
QContext init and clear around the call; the presenter stays one per turn
through ToolCallScope.state).
- TurnEngine.recordToolResult: the row is built by ToolCallService.log; the
bulk-load log reduction and search_knowledge's operation are the tools'
forLog and operationWithoutDetail.
- AssistantApi.confirmAction: the if-chain is
ToolCallService.executeConfirmed; the row is ToolCallService.logConfirmed.
UiApiToolbox, AnalysisTools, BulkLoadTools, KnowledgeTool, PresentResultsTool
and the core kernel keep all of their behaviour. A tool family is a class
under com.kingsrook.qbits.assistant.tools that implements ToolFamily; it is
found at startup, so a new family is new files only. The kernel family lives
in engine and is named by the runtime, because nothing under tools may touch
the kernel (ArchitectureTest).
Tests: ChatToolSetTest compares the chat's tool list (names, order,
descriptions, schemas, strict flags, in six scenarios) with the list written
from origin/develop at e02658d before any production code changed.
ToolCallChecksTest (permission, tool switch, data access, the person's own
request, confirmation, and the log row of each refusal) passes unchanged on
the code before and after. ToolRegistryTest and ToolCallArchitectureTest cover
the registry and bind 'only ToolCallService runs or logs a tool call'. No
existing test changed.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Moves qqq.snapshot.version from 4.1.0-RC.25 to 4.1.0-RC.32, the version
applications (GG Forge) pin. No behaviour change.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
james.maesandClaude Fable 5.2