QRun-IO/qbit-assistant
0
0 Fork 0
Code Issues 3 Pull Requests 7 Actions Packages Projects Releases 23 Wiki Activity

fix(runtime): shutdown hook holds the runtime weakly #57

Merged
KofTwentyTwo merged 1 commits from fix/shutdown-hook-weak-runtime into develop 2026-10-15 20:57:50 +00:00
Conversation 0 Commits 1 Files Changed 1
+13 -1
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
qbit-assistant/src/main/java/com/kingsrook/qbits/assistant/AssistantRuntime.java
+13 -1
View File
@@ -17,6 +17,7 @@
package com.kingsrook.qbits.assistant;
import java.lang.ref.WeakReference;
import java.net.InetAddress;
import java.time.Clock;
import java.time.Duration;
@@ -178,11 +179,22 @@ public class AssistantRuntime
this.contextBuilder = new ContextBuilder(config, kernel, toolbox).withKnowledgeTool(knowledgeTool).withBulkLoadTools(bulkLoadTools);
if(Boolean.TRUE.equals(config.getRegisterShutdownHook()))
{
///////////////////////////////////////////////////////////////////////
// the hook holds the runtime weakly: a runtime (and its QInstance) //
// that is dropped without shutdown() - every test that builds an //
// instance - must not stay reachable from the JVM's hooks //
///////////////////////////////////////////////////////////////////////
WeakReference<AssistantRuntime> self = new WeakReference<>(this);
Integer graceSeconds = config.getShutdownGraceSeconds();
shutdownHook = new Thread(() ->
{
try
{
shutdown(Duration.ofSeconds(config.getShutdownGraceSeconds()));
AssistantRuntime runtime = self.get();
if(runtime != null)
{
runtime.shutdown(Duration.ofSeconds(graceSeconds));
}
}
catch(Throwable ignored)
{