build(deps): Bump the github-actions group with 2 updates

Bumps the github-actions group with 2 updates: [QRun-IO/qqq-orb/.github/workflows/qbit-codeql.yml](https://github.com/qrun-io/qqq-orb) and [QRun-IO/qqq-orb/.github/workflows/qbit-release-rc.yml](https://github.com/qrun-io/qqq-orb).


Updates `QRun-IO/qqq-orb/.github/workflows/qbit-codeql.yml` from c288a8864fe9054f68410e1d78f5863aea4c4d22 to 1c389210e6dfda1630d053c07ae4dae523dd5576
- [Release notes](https://github.com/qrun-io/qqq-orb/releases)
- [Changelog](https://github.com/QRun-IO/qqq-orb/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/qrun-io/qqq-orb/compare/c288a8864fe9054f68410e1d78f5863aea4c4d22...1c389210e6dfda1630d053c07ae4dae523dd5576)

Updates `QRun-IO/qqq-orb/.github/workflows/qbit-release-rc.yml` from cc30f599e63c8e41629c99d23395bac1adb8bc44 to 1c389210e6dfda1630d053c07ae4dae523dd5576
- [Release notes](https://github.com/qrun-io/qqq-orb/releases)
- [Changelog](https://github.com/QRun-IO/qqq-orb/blob/develop/CHANGELOG.md)
- [Commits](https://github.com/qrun-io/qqq-orb/compare/cc30f599e63c8e41629c99d23395bac1adb8bc44...1c389210e6dfda1630d053c07ae4dae523dd5576)

---
updated-dependencies:
- dependency-name: QRun-IO/qqq-orb/.github/workflows/qbit-codeql.yml
  dependency-version: 1c389210e6dfda1630d053c07ae4dae523dd5576
  dependency-type: direct:production
  dependency-group: github-actions
- dependency-name: QRun-IO/qqq-orb/.github/workflows/qbit-release-rc.yml
  dependency-version: 1c389210e6dfda1630d053c07ae4dae523dd5576
  dependency-type: direct:production
  dependency-group: github-actions
...

Signed-off-by: dependabot[bot] <support@github.com>

.github/workflows/codeql.yml

@@ -20,4 +20,4 @@ concurrency:
   cancel-in-progress: ${{ github.event_name == 'pull_request' }}
 jobs:
   analyze:
-    uses: QRun-IO/qqq-orb/.github/workflows/qbit-codeql.yml@c288a8864fe9054f68410e1d78f5863aea4c4d22
+    uses: QRun-IO/qqq-orb/.github/workflows/qbit-codeql.yml@1c389210e6dfda1630d053c07ae4dae523dd5576

.github/workflows/release-rc.yml

@@ -53,7 +53,7 @@ jobs:
       || (github.event_name == 'pull_request' && github.event.pull_request.merged
       == true && github.event.pull_request.base.ref == 'develop' && contains(github.event.pull_request.labels.*.name,
       'release:rc'))
-    uses: QRun-IO/qqq-orb/.github/workflows/qbit-release-rc.yml@cc30f599e63c8e41629c99d23395bac1adb8bc44
+    uses: QRun-IO/qqq-orb/.github/workflows/qbit-release-rc.yml@1c389210e6dfda1630d053c07ae4dae523dd5576
     with:
       dry_run: ${{ github.event_name == 'workflow_dispatch' && inputs.dry_run || false
         }}

CHANGELOG.md

@@ -27,7 +27,6 @@ All notable changes are documented here, following [Keep a Changelog](https://ke
 ### Fixed
 
 - QBit metadata reports the Maven artifact version from a filtered resource, including release versions.
-- `presence.changed` events and presence snapshots always carry `viewers`, sending `[]` once the last viewer leaves, as the schema requires (#52).
 
 - Timeline audit summaries read "Edited by Alice Morgan: Title, Total" or "Created by Alice Morgan" instead of "Record was Edited"; detail rows are unchanged.
 - The demo server chooses its user per browser session (`?user=bob`, remembered in a cookie) instead of once per JVM, and sends the person's name to the frontend so it no longer shows Anonymous.

src/main/java/com/kingsrook/qbits/collaboration/api/CollaborationPresenceSchemas.java

@@ -24,7 +24,6 @@ package com.kingsrook.qbits.collaboration.api;
 import java.util.List;
 import java.util.Map;
 import java.util.TreeMap;
-import com.fasterxml.jackson.annotation.JsonInclude;
 import com.kingsrook.qbits.collaboration.presence.PresenceRegistry;
 import com.kingsrook.qqq.middleware.javalin.schemabuilder.ToSchema;
 import com.kingsrook.qqq.openapi.model.Schema;
@@ -81,10 +80,9 @@ public final class CollaborationPresenceSchemas
    }
 
    /*******************************************************************************
-    ** The snapshot is also the data shape of presence.changed events. Viewers are
-    ** included even when empty, whatever inclusion the serializer defaults to.
+    ** The snapshot is also the data shape of presence.changed events.
     *******************************************************************************/
-   public record CollaborationPresenceSnapshotV1(String table, String pk, @JsonInclude(JsonInclude.Include.ALWAYS) List<PresenceRegistry.Viewer> viewers) implements ToSchema
+   public record CollaborationPresenceSnapshotV1(String table, String pk, List<PresenceRegistry.Viewer> viewers) implements ToSchema
    {
       /*******************************************************************************
        ** A table snapshot deliberately excludes record ids and focused field names.
@@ -95,7 +93,7 @@ public final class CollaborationPresenceSchemas
          return (new Schema().withType(Type.OBJECT).withDescription("Live viewers, merged across tabs; presence.changed uses this payload.")
             .withProperties(new TreeMap<>(Map.of(
                "table", text("Parent table name.", false), "pk", text("Record key; absent for table events.", true),
-               "viewers", new Schema().withType(Type.ARRAY).withDescription("Live viewers; always present, empty once the last viewer leaves.").withNullable(false).withItems(new Schema().withRefToSchema("CollaborationPresenceViewerV1"))))));
+               "viewers", new Schema().withType(Type.ARRAY).withItems(new Schema().withRefToSchema("CollaborationPresenceViewerV1"))))));
       }
    }
 

src/main/java/com/kingsrook/qbits/collaboration/presence/PresenceRegistry.java

@@ -21,7 +21,6 @@
 
 package com.kingsrook.qbits.collaboration.presence;
 
-import java.io.IOException;
 import java.io.Serializable;
 import java.time.Clock;
 import java.util.ArrayList;
@@ -34,10 +33,6 @@ import java.util.WeakHashMap;
 import java.util.concurrent.Executors;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
-import com.fasterxml.jackson.core.JsonGenerator;
-import com.fasterxml.jackson.databind.SerializerProvider;
-import com.fasterxml.jackson.databind.annotation.JsonSerialize;
-import com.fasterxml.jackson.databind.ser.std.StdSerializer;
 import com.kingsrook.qqq.backend.core.logging.QLogger;
 import com.kingsrook.qqq.backend.core.model.metadata.QInstance;
 import com.kingsrook.qqq.backend.core.realtime.RealtimeBus;
@@ -328,7 +323,7 @@ public final class PresenceRegistry implements AutoCloseable
       {
          data.put("pk", pk);
       }
-      Viewers viewers = new Viewers();
+      ArrayList<LinkedHashMap<String, Serializable>> viewers = new ArrayList<>();
       synchronized(this)
       {
          for(Viewer viewer : snapshotInternal(table, pk))
@@ -345,61 +340,6 @@ public final class PresenceRegistry implements AutoCloseable
       bus.publish(new RealtimeMessage().withChannel(channel).withEvent("presence.changed").withData(data));
    }
 
-   /*******************************************************************************
-    ** Event viewers list that is never omitted: the SSE writer serializes event data
-    ** with NON_EMPTY inclusion, which would drop an empty list, but the schema
-    ** declares viewers a required array, so the last leave must send [] (#52).
-    *******************************************************************************/
-   @JsonSerialize(using = ViewersSerializer.class)
-   public static final class Viewers extends ArrayList<LinkedHashMap<String, Serializable>>
-   {
-   }
-
-
-
-   /*******************************************************************************
-    ** Writes each viewer with the caller's mapper settings and reports never empty.
-    *******************************************************************************/
-   public static final class ViewersSerializer extends StdSerializer<Viewers>
-   {
-      /*******************************************************************************
-       ** Jackson instantiates the serializer reflectively.
-       *******************************************************************************/
-      public ViewersSerializer()
-      {
-         super(Viewers.class);
-      }
-
-
-
-      /*******************************************************************************
-       ** Always an array, including the empty array after the last viewer leaves.
-       *******************************************************************************/
-      @Override
-      public void serialize(Viewers viewers, JsonGenerator generator, SerializerProvider provider) throws IOException
-      {
-         generator.writeStartArray(viewers, viewers.size());
-         for(LinkedHashMap<String, Serializable> viewer : viewers)
-         {
-            provider.defaultSerializeValue(viewer, generator);
-         }
-         generator.writeEndArray();
-      }
-
-
-
-      /*******************************************************************************
-       ** NON_EMPTY inclusion consults this; an empty viewer list is still a value.
-       *******************************************************************************/
-      @Override
-      public boolean isEmpty(SerializerProvider provider, Viewers viewers)
-      {
-         return (false);
-      }
-   }
-
-
-
    /*******************************************************************************
     ** Release listeners and timer on host shutdown or in tests.
     *******************************************************************************/

src/main/resources/openapi/qqq-v1/collaboration.yaml

@@ -758,10 +758,8 @@ components:
           nullable: false
           type: "string"
         viewers:
-          description: "Live viewers; always present, empty once the last viewer leaves."
           items:
             $ref: "#/components/schemas/CollaborationPresenceViewerV1"
-          nullable: false
           type: "array"
       type: "object"
     CollaborationPresenceViewerV1:

src/test/java/com/kingsrook/qbits/collaboration/PresenceTest.java

@@ -24,10 +24,8 @@ package com.kingsrook.qbits.collaboration;
 import java.time.Clock;
 import java.time.Instant;
 import java.time.ZoneId;
-import java.util.LinkedHashMap;
 import java.util.List;
 import java.util.concurrent.CopyOnWriteArrayList;
-import com.kingsrook.qbits.collaboration.api.CollaborationPresenceSchemas;
 import com.kingsrook.qbits.collaboration.presence.PresenceRegistry;
 import com.kingsrook.qbits.collaboration.presence.PresenceService;
 import com.kingsrook.qbits.collaboration.app.CollaborationHome;
@@ -38,7 +36,6 @@ import com.kingsrook.qqq.backend.core.model.metadata.collaboration.RecordFeature
 import com.kingsrook.qqq.backend.core.model.metadata.collaboration.RecordFeaturesMetaData;
 import com.kingsrook.qqq.backend.core.realtime.InMemoryRealtimeBus;
 import com.kingsrook.qqq.backend.core.realtime.RealtimeMessage;
-import com.kingsrook.qqq.backend.core.utils.JsonUtils;
 import org.junit.jupiter.api.Test;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
@@ -90,46 +87,6 @@ class PresenceTest extends PersonalServiceFixture
       }
    }
 
-   /*******************************************************************************
-    ** The last leave still sends viewers: the SSE writer and the HTTP snapshot must
-    ** both carry an empty array, never omit the field (#52).
-    *******************************************************************************/
-   @Test
-   void lastLeaveSendsEmptyViewers() throws Exception
-   {
-      var clock = new MutableClock();
-      try(var bus = new InMemoryRealtimeBus(); var registry = new PresenceRegistry(bus, clock, PresenceRegistry.MAX_ENTRIES))
-      {
-         List<RealtimeMessage> events = new CopyOnWriteArrayList<>();
-         bus.subscribe(events::add);
-         registry.heartbeat("bob", "Bob", "one", "person", null, "VIEWING", null);
-         registry.heartbeat("bob", "Bob", "one", "person", "7", "EDITING", "name");
-         registry.leave("bob", "one", "person", null);
-         registry.leave("bob", "one", "person", "7");
-         assertThat(registry.snapshot("person", null)).isEmpty();
-
-         for(String channel : List.of("table:person", "record:person:7"))
-         {
-            RealtimeMessage last = events.stream().filter(event -> event.getChannel().equals(channel) && event.getEvent().equals("presence.changed")).reduce((first, second) -> second).orElseThrow();
-            assertThat(last.getData()).containsKey("viewers");
-            assertThat((List<?>) last.getData().get("viewers")).isEmpty();
-
-            ///////////////////////////////////////////////////////////////////////
-            // the realtime hub copies the data map and writes it with toJson,   //
-            // whose NON_EMPTY inclusion used to drop the empty viewers list     //
-            ///////////////////////////////////////////////////////////////////////
-            String json = JsonUtils.toJson(new LinkedHashMap<>(last.getData()));
-            assertThat(JsonUtils.toJSONObject(json).getJSONArray("viewers").length()).isZero();
-         }
-
-         String occupied = JsonUtils.toJson(events.stream().filter(event -> event.getChannel().equals("record:person:7")).findFirst().orElseThrow().getData());
-         assertThat(JsonUtils.toJSONObject(occupied).getJSONArray("viewers").getJSONObject(0).getString("fieldName")).isEqualTo("name");
-
-         var snapshot = new CollaborationPresenceSchemas.CollaborationPresenceSnapshotV1("person", null, registry.snapshot("person", null));
-         assertThat(JsonUtils.toJSONObject(JsonUtils.toJson(snapshot)).getJSONArray("viewers").length()).isZero();
-      }
-   }
-
    /*******************************************************************************
     ** At capacity, existing leases renew while new targets are refused on both pods.
     *******************************************************************************/