fix: reject private analyses without a read owner #37

Merged

james.maes merged 1 commits from james.maes/fix-private-analysis-read-owner AGit into develop 2026-11-03 21:01:42 +00:00

Conversation 0 Commits 1 Files Changed 4

+98 -2

james.maes commented 2026-11-03 18:27:32 +00:00

Owner

Copy link

Copy source

The generated saved-analysis constraint accepted NULL sharing and a NULL read owner because SQL CHECK allows UNKNOWN, making a direct-SQL private row readable as shared. Require shared IS TRUE before omitting its read owner; normal QQQ writes remain unchanged. Existing hosts must append the documented migration. Validation: the original defect reproduced; 314 tests, Checkstyle and coverage gates pass via Maven wrapper 3.9.11 against exact QQQ RC.20. GG Forge also verified the forward constraint against PostgreSQL 17.7. No release or deployment is claimed.

The generated saved-analysis constraint accepted NULL sharing and a NULL read owner because SQL CHECK allows UNKNOWN, making a direct-SQL private row readable as shared. Require shared IS TRUE before omitting its read owner; normal QQQ writes remain unchanged. Existing hosts must append the documented migration. Validation: the original defect reproduced; 314 tests, Checkstyle and coverage gates pass via Maven wrapper 3.9.11 against exact QQQ RC.20. GG Forge also verified the forward constraint against PostgreSQL 17.7. No release or deployment is claimed.

james.maes added 1 commit 2026-11-03 18:27:32 +00:00

fix: reject private analyses without a read owner ... 2dcc073f51

Use an explicit true sharing check so nullable flags cannot pass SQL CHECK as UNKNOWN. Add a generated-schema SQL regression and document the forward host migration.

Co-Authored-By: Codex (GPT-6) <noreply@openai.com>

james.maes merged commit e7926cbb20 into develop 2026-11-03 21:01:42 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

architecture

Architecture review: coupling, cohesion, UI API

bug

Something isn't working

dependencies

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

github_actions

Pull requests that update GitHub Actions code

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

java

Pull requests that update java code

question

Further information is requested

secuurity

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QRun-IO/qbit-data-analysis#37