fix(home): File Gateway tile directions and reasoned empty tables #19

Merged
KofTwentyTwo merged 1 commits from fix/file-gateway-increase-is-good into develop 2026-10-16 15:19:55 +00:00
KofTwentyTwo commented 2026-10-16 14:10:47 +00:00 (Migrated from github.com)

Summary

  • The failures ("Failed jobs (24 hours)") and locked ("Locked accounts") statistics tiles inherited the StatisticsData default increaseIsGood=true. They now set increaseIsGood=false. Every tile's direction is now explicit: transfers, MB in, MB out and active sessions are volume/neutral (true); failures and locks are bad (false).
  • The four home tables set noRowsFoundHTML with a reason: "No failed transfers in the last 7 days." (Recent failures uses a 7-day window), "No partner has transferred a file in the last 7 days.", "No one is connected right now (no session has been seen in the last 3 minutes).", "No gateway server has reported in during the last 3 minutes."

Rubric item moved

A3 correctness and A7 empty states on File Gateway (file_gateway).

Audit row fixed

File Gateway A3: "Failed jobs (24 hours)" and "Locked accounts" declare increaseIsGood: true (wrong direction). A7: "All 4 tables have no noRowsFoundHTML".

Tests

PhaseEIntegrationTest (4 tests pass via ./mvnw): asserts the direction of every tile and that each of the four tables has a non-blank noRowsFoundHTML (with the no-session case asserted against an actually empty table). Full verify left to CI.

Screenshots

No visual change for the flag. Empty tables: a widget-level mock built from the exact empty-text strings, at six widths, attached locally: C:\Users\james\AppData\Local\Temp\claude\R--Git-Local-KofTwentyTwo-Praetor\83da0ae2-628c-4edb-9fd7-a93d49e86d27\scratchpad\dashboard-standard\pr-shots\file-gateway-flags\. Full-page shots happen when kof22 pins the release.

Release

A qbit-file-gateway RC release is needed (after 0.1.0-RC.4). kof22 (Website-Backend) pom.xml currently pins qbit-file-gateway.version 0.1.0-RC.4 on origin/main and must be bumped to the new RC.

🤖 Generated with Claude Code

## Summary - The `failures` ("Failed jobs (24 hours)") and `locked` ("Locked accounts") statistics tiles inherited the `StatisticsData` default `increaseIsGood=true`. They now set `increaseIsGood=false`. Every tile's direction is now explicit: transfers, MB in, MB out and active sessions are volume/neutral (`true`); failures and locks are bad (`false`). - The four home tables set `noRowsFoundHTML` with a reason: "No failed transfers in the last 7 days." (Recent failures uses a 7-day window), "No partner has transferred a file in the last 7 days.", "No one is connected right now (no session has been seen in the last 3 minutes).", "No gateway server has reported in during the last 3 minutes." ## Rubric item moved A3 correctness and A7 empty states on File Gateway (`file_gateway`). ## Audit row fixed File Gateway A3: "Failed jobs (24 hours)" and "Locked accounts" declare `increaseIsGood: true` (wrong direction). A7: "All 4 tables have no noRowsFoundHTML". ## Tests `PhaseEIntegrationTest` (4 tests pass via `./mvnw`): asserts the direction of every tile and that each of the four tables has a non-blank `noRowsFoundHTML` (with the no-session case asserted against an actually empty table). Full verify left to CI. ## Screenshots No visual change for the flag. Empty tables: a widget-level mock built from the exact empty-text strings, at six widths, attached locally: `C:\Users\james\AppData\Local\Temp\claude\R--Git-Local-KofTwentyTwo-Praetor\83da0ae2-628c-4edb-9fd7-a93d49e86d27\scratchpad\dashboard-standard\pr-shots\file-gateway-flags\`. Full-page shots happen when kof22 pins the release. ## Release A qbit-file-gateway RC release is needed (after 0.1.0-RC.4). kof22 (Website-Backend) `pom.xml` currently pins `qbit-file-gateway.version` 0.1.0-RC.4 on origin/main and must be bumped to the new RC. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.