fix(realtime): resolve the device on the authorized upgrade (lowercase headers); 1.1.1 #30

Merged

james.maes merged 1 commits from fix/realtime-header-case-20261106 into main 2026-11-06 15:31:00 +00:00

Conversation 0 Commits 1 Files Changed 7

+87 -7

james.maes commented 2026-11-06 14:24:57 +00:00

Owner

Copy link

Copy source

Forge's adoption qualification of released 1.1.0 reproduced a realtime failure before WELCOME when upgrade header names arrive lowercase (ingress normalization): WsContext.header is case-sensitive, so the device was null and channels.put threw. Fix: resolve the device once on the authorized HTTP upgrade and carry it as a connection attribute (same approach as Forge's local patch). Regression test with lowercase header names covers WELCOME, inventory ACK, PRINTERS push and socket replacement; it fails on main with the same NPE. Full gate: 200 tests, 0 failures, 0 Checkstyle. Version 1.1.1; no contract change.

🤖 Generated with Claude Code

Forge's adoption qualification of released 1.1.0 reproduced a realtime failure before WELCOME when upgrade header names arrive lowercase (ingress normalization): WsContext.header is case-sensitive, so the device was null and channels.put threw. Fix: resolve the device once on the authorized HTTP upgrade and carry it as a connection attribute (same approach as Forge's local patch). Regression test with lowercase header names covers WELCOME, inventory ACK, PRINTERS push and socket replacement; it fails on main with the same NPE. Full gate: 200 tests, 0 failures, 0 Checkstyle. Version 1.1.1; no contract change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james.maes added 1 commit 2026-11-06 14:24:57 +00:00

fix(realtime): resolve the device on the authorized upgrade so lowercase headers connect; 1.1.1 ... e7721bdf90

The WebSocket callbacks read X-QQQ-Device-Id from the socket context, whose
header lookup is case-sensitive, while the HTTP upgrade matches names
case-insensitively. Behind an ingress that lowercases header names the device
resolved to null on connect and channels.put threw before WELCOME (Forge's
adoption test of released 1.1.0; Forge had carried a local patch on 1.0.0).
Resolve the device once after authorization on the upgrade and carry it as a
connection attribute for connect, message and close. The new
lowercaseUpgradeHeadersReachWelcomeAndFrames test fails on the previous code
with the same NullPointerException and passes here. No contract change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes merged commit 2a561815fc into main 2026-11-06 15:31:00 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

github_actions

Pull requests that update GitHub Actions code

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

java

Pull requests that update java code

question

Further information is requested

secuurity

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QRun-IO/qbit-printing#30