fix(#17): log count failures instead of swallowing them #21

Merged

KofTwentyTwo merged 2 commits from feature/GH-17-log-safecount into develop

2026-10-07 00:03:17 +00:00

Author	SHA1	Message	Date
james.maes	4585b0144d	fix(#17 ): keep the previous documentCount when the count fails A failed count no longer overwrites documentCount with null; the three callers now skip the field, and BasepullIndexStep reuses ReconcileIndexStep.safeCount instead of its own copy. Refs #17	2026-10-06 18:17:57 -05:00
james.maes	b9446d59c5	fix(#17 ): log count failures instead of swallowing them Both safeCount helpers (BasepullIndexStep and ReconcileIndexStep, which FullReindexStep also uses) now log a WARN with the exception and tableName before returning null, so a failing document count is visible while the run behaves as before. Closes #17	2026-10-06 18:04:37 -05:00

Author

SHA1

Message

Date

james.maes

4585b0144d

fix(#17 ): keep the previous documentCount when the count fails

A failed count no longer overwrites documentCount with null; the three callers now skip the field, and BasepullIndexStep reuses ReconcileIndexStep.safeCount instead of its own copy.

Refs #17

2026-10-06 18:17:57 -05:00

james.maes

b9446d59c5

fix(#17 ): log count failures instead of swallowing them

Both safeCount helpers (BasepullIndexStep and ReconcileIndexStep, which FullReindexStep also uses) now log a WARN with the exception and tableName before returning null, so a failing document count is visible while the run behaves as before.

Closes #17

2026-10-06 18:04:37 -05:00