QRun-IO/qqq-cli
2
0 Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 1 Wiki Activity

fix(core): DPAPI keyring works when started from PowerShell 7 #18

Merged
james.maes merged 1 commits from fix/dpapi-psmodulepath into main 2026-11-08 14:03:20 +00:00
Conversation 0 Commits 1 Files Changed 2
+11 -1
james.maes commented 2026-11-08 14:02:13 +00:00
Owner
Copy link
Copy source

Release run 7188 (Windows native lane, steps in pwsh 7) failed the existing DPAPI test: Windows PowerShell 5.1 spawned from pwsh inherits PowerShell 7's PSModulePath and cannot load Microsoft.PowerShell.Security (ConvertTo-SecureString). Reproduced locally; real user impact for anyone running qqq from a pwsh 7 terminal. The keyring now spawns PowerShell without PSModulePath. Core tests 278/278 locally on Windows (DPAPI test passes). CHANGELOG 1.0.1-rc.1 Fixed entry added. v1.0.1-rc.1 will be retagged on the merge commit; the draft release from run 7188 is deleted first.

🤖 Generated with Claude Code

Release run 7188 (Windows native lane, steps in pwsh 7) failed the existing DPAPI test: Windows PowerShell 5.1 spawned from pwsh inherits PowerShell 7's PSModulePath and cannot load Microsoft.PowerShell.Security (ConvertTo-SecureString). Reproduced locally; real user impact for anyone running qqq from a pwsh 7 terminal. The keyring now spawns PowerShell without PSModulePath. Core tests 278/278 locally on Windows (DPAPI test passes). CHANGELOG 1.0.1-rc.1 Fixed entry added. v1.0.1-rc.1 will be retagged on the merge commit; the draft release from run 7188 is deleted first. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
james.maes added 1 commit 2026-11-08 14:02:13 +00:00
fix(core): DPAPI keyring works when started from PowerShell 7
node / node (push) Successful in 44s
Details
build / node (push) Successful in 44s
Details
1c54e7fae0 
Started from pwsh 7, the child Windows PowerShell 5.1 inherits PowerShell 7's
PSModulePath and cannot load Microsoft.PowerShell.Security, so
ConvertTo-SecureString fails and every DPAPI set/get reports "Windows
credential protection failed". The release workflow's Windows lane (steps in
pwsh) hit it in the existing DPAPI test. The keyring now spawns PowerShell
without PSModulePath; each shell computes its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
james.maes merged commit a4750b68ad into main 2026-11-08 14:03:20 +00:00
james.maes deleted branch fix/dpapi-psmodulepath 2026-11-08 14:03:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
 dependencies
documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 question
Further information is requested
 secuurity
wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: QRun-IO/qqq-cli#18