feat: client editions with fully branded builds, installers and update assets #10

Merged

james.maes merged 13 commits from feat/client-editions-20261105 into main 2026-11-05 23:14:51 +00:00

Conversation 0 Commits 13 Files Changed 75

+1963 -161

james.maes commented 2026-11-05 16:51:43 +00:00

Owner

Copy link

Copy source

Summary

• Editions: editions/<id>/ holds edition.json (names, accent, asset prefix), app-icon.svg, app.ico and an optional logo.png. ./build/Build-Installer.ps1 -Edition <id> builds a fully branded companion, service and CLI (product, company and file description metadata; the client's mark on splash and About; the client's icon on window, taskbar, executable and Start menu; logo in Settings) and an MSI named <assetPrefix>-<version>-x64.msi whose product name, manufacturer and service display name are the client's and are forced over any stored labels.
• Updates stay on the client's line: the companion's updater looks for <assetPrefix>-v<version>-x64.msi, so a client install is never offered the generic MSI (or another client's).
• Every customer, every release: CI builds each edition's unsigned installer; the stable release workflow enumerates editions/, runs the sign chain once per edition and once for the generic build (matrix), re-verifies every signature in a new assemble job, and publishes all installers with one SHA256SUMS. Package-Release.ps1 includes every edition and refuses to drop one.
• Shared across editions: application id, data paths, executable file names, install directory, protocol handler, MSI upgrade identity and signing identity, so editions and the generic build upgrade each other in place. Deployment branding (Install-Branded.ps1) still applies on top.
• First edition: gg-forge (GG Forge Print Agent, Greater Goods, #424242, mark rendered from the server's advertised icon). Version 1.2.0. Docs: editions/README.md, BRANDING.md, RELEASING.md, CHANGELOG.

Verification

• NativeCI solution: zero warnings. Qqq.PrintAgent.Cli.Tests: 352 passed. New EditionTests (Core) run on hosted CI.
• Build-Installer.ps1 -Edition gg-forge built GgForgePrintAgent-1.1.1-x64.msi and GgForgePrintAgent-1.2.0-x64.msi locally; the Property table carries the forced GG Forge name and company, all three executables report GG Forge product/company/description, and the descriptor, mark, icon and logo ship in the payload. The script's own checks compare the published artwork hashes to the edition folder.
• Gates: PSScriptAnalyzer (16 scripts, no findings), actionlint and zizmor on the workflows, source headers (300 files), packaging-input and branded-installer dry runs.
• The release-workflow matrix and assemble job can only be exercised by a stable tag; the first v1.2.0 run is the acceptance for that path.

Substantial AI assistance was used for this change.

🤖 Generated with Claude Code

## Summary - **Editions**: `editions/<id>/` holds `edition.json` (names, accent, asset prefix), `app-icon.svg`, `app.ico` and an optional `logo.png`. `./build/Build-Installer.ps1 -Edition <id>` builds a fully branded companion, service and CLI (product, company and file description metadata; the client's mark on splash and About; the client's icon on window, taskbar, executable and Start menu; logo in Settings) and an MSI named `<assetPrefix>-<version>-x64.msi` whose product name, manufacturer and service display name are the client's and are forced over any stored labels. - **Updates stay on the client's line**: the companion's updater looks for `<assetPrefix>-v<version>-x64.msi`, so a client install is never offered the generic MSI (or another client's). - **Every customer, every release**: CI builds each edition's unsigned installer; the stable release workflow enumerates `editions/`, runs the sign chain once per edition and once for the generic build (matrix), re-verifies every signature in a new `assemble` job, and publishes all installers with one `SHA256SUMS`. `Package-Release.ps1` includes every edition and refuses to drop one. - Shared across editions: application id, data paths, executable file names, install directory, protocol handler, MSI upgrade identity and signing identity, so editions and the generic build upgrade each other in place. Deployment branding (`Install-Branded.ps1`) still applies on top. - First edition: `gg-forge` (GG Forge Print Agent, Greater Goods, #424242, mark rendered from the server's advertised icon). Version 1.2.0. Docs: `editions/README.md`, BRANDING.md, RELEASING.md, CHANGELOG. ## Verification - NativeCI solution: zero warnings. `Qqq.PrintAgent.Cli.Tests`: 352 passed. New `EditionTests` (Core) run on hosted CI. - `Build-Installer.ps1 -Edition gg-forge` built `GgForgePrintAgent-1.1.1-x64.msi` and `GgForgePrintAgent-1.2.0-x64.msi` locally; the Property table carries the forced GG Forge name and company, all three executables report GG Forge product/company/description, and the descriptor, mark, icon and logo ship in the payload. The script's own checks compare the published artwork hashes to the edition folder. - Gates: PSScriptAnalyzer (16 scripts, no findings), actionlint and zizmor on the workflows, source headers (300 files), packaging-input and branded-installer dry runs. - The release-workflow matrix and assemble job can only be exercised by a stable tag; the first `v1.2.0` run is the acceptance for that path. Substantial AI assistance was used for this change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

james.maes added 1 commit 2026-11-05 16:51:44 +00:00

feat: client editions with fully branded builds, installers and update assets ... f8b85ddd83

A folder under editions/<id> (descriptor, SVG mark, ICO icon, optional logo) and
Build-Installer.ps1 -Edition <id> produce a fully branded build and installer: the
client's mark and icon on the splash, About, window, taskbar and Start menu; the
client's product, company and file description in every executable; the client's
product name, manufacturer and service display name in the MSI, forced over any
stored labels; the MSI and release asset named after the edition's asset prefix;
and the installed updater following that asset on the shared feed, so a client
install only ever sees its own edition.

CI builds every edition's unsigned installer. The stable release workflow lists
the editions, signs and publishes one installer per edition beside the generic
one through a matrix sign job and an assemble job that re-verifies every
signature and writes a single SHA256SUMS. Package-Release.ps1 includes every
edition. First edition: gg-forge (GG Forge Print Agent by Greater Goods).
Version 1.2.0. No wire change.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 16:55:58 +00:00

test: satisfy IDE0005/IDE0007 in EditionTests ... 9d52231d7e

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 17:17:16 +00:00

feat: edition builds ignore installer-written labels; harness captures edition identity ... 4ee980eb76

RuntimeBranding.LoadMachine takes includeInstallerLabels; an edition build skips the
DisplayName/CompanyName the installer persisted so labels from an earlier generic install
cannot relabel the edition, while the machine branding file still applies on top. The
companion's log is typed through a new IAgentLog interface so the layout harness can
supply its per-user log; the harness answers get-server-trust and, with
QQQ_LAYOUT_CAPTURE_EDITION=1, captures the splash, window, Settings page and About
dialog with the build's real identity as evidence.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 17:29:14 +00:00

feat: edition options for server wording and About sections ... 397b60026a

An edition descriptor may set serverName (what user-facing text calls the server;
the generic build keeps QQQ), and aboutMascot/aboutLicense (default true) to leave
the Query mascot and License sections out of the About dialog while the header and
Open source components stay. The generic build is unchanged. About composition moves
to AboutContent so the window and the layout harness render the same dialog. The
gg-forge edition sets serverName to GG Forge and turns both sections off.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 17:50:55 +00:00

Merge remote-tracking branch 'origin/main' into feat/client-editions-20261105 0b9ded7bf7

james.maes added 1 commit 2026-11-05 18:37:38 +00:00

feat(auth): send the sign-in nonce under OPTIONAL and the discovery capability; shared-CI packaging entrypoint ... c59814d713

The exchange carries the attempt's own nonce as expectedNonce when the grant policy
is REQUIRED or OPTIONAL, or when discovery advertises nativeSessionNonceValidation
and the grant states no policy; legacy servers keep the unchanged body and other
policy values are still refused before a browser opens. The decision is logged
without the nonce. build/Build-CiRelease.ps1 delegates to Package-Release.ps1 so
the shared Gitea .NET CI packages the generic and every edition installer through
the one packaging path. Docs, CHANGELOG and TODO updated.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 18:38:20 +00:00

docs: session state for 2026-11-05 (1.1.1 released, PR 10 pending Gitea runner) ... 548d831d2c

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 20:40:10 +00:00

fix(ui): widen the connection dialog and group it into three short steps ... ac582e7bff

The content dialog's default width clipped the sign-in form. The dialog now allows
760 px, disables horizontal overflow, wraps the certificate checkbox label, folds the
long certificate explanation into a one-line caption with the detail on hover, groups
the form into Server, Sign in and New pairing steps with caption-style guidance, and
puts the sign-in actions on one row. The layout harness captures the dialog in
edition-capture mode.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 21:09:37 +00:00

feat(printers): show each shared printer's approval on the connected server ... 887c58cd31

The device routes never report approval, so the service reads the server's
operator printer catalog after each accepted inventory and about once a minute
while connected, keeps the per-device approved set in memory (reset with the
connection), and the snapshot carries APPROVED / AWAITING_APPROVAL / NOT_SHARED
/ NOT_REPORTED (with the reason) / NOT_CHECKED per printer plus the last reading.
The Printers page shows it in a new Server column, the summary line and the
expanded details, named for the connected server. The session client admits the
catalog read (GET operator/printers) and nothing else from the operator API.

Also: a Clear logs button on the shared activity log viewer, the connection
dialog's result banner pinned above the scrolling form with a waiting state
during browser and password sign-in, and a service sign-in reply that no longer
repeats itself.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 21:17:29 +00:00

fix(tests): var for apparent types in the catalog test; document printer approval and the proposed device-facing extension ... d401146985

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 21:40:14 +00:00

feat(realtime): negotiate printer-approval-v1 and take approval from the server's PRINTERS frame ... 86c7a5e6d3

Printing extension 2.4 (QBit 1.1.0, protocol 1.1.0): when discovery advertises a
stable 2.4-or-newer printing extension the HELLO carries printer-approval-v1 and
the server's PRINTERS frame (every printer in the latest accepted inventory with
its approval, pushed after each inventory and on every approval change) becomes
the authoritative per-printer server state; the operator catalog is not read on
such a server. Older servers keep the 2.3 catalog fallback and an unchanged wire.
The capability is re-evaluated on every socket, the reading is reset with the
connection, and the companion's tooltip says whether approval is pushed or polled.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 21:47:08 +00:00

test(core): read the shared PRINTERS fixture; pin protocol fixtures to 1.1.0 (ac835f8) ... f1ec4040ce

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes added 1 commit 2026-11-05 22:13:41 +00:00

docs: session state for the printer-approval work across protocol, QBit and client ... 73e36c61a3

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>

james.maes scheduled this pull request to auto merge when all checks succeed 2026-11-05 23:10:46 +00:00

james.maes closed this pull request 2026-11-05 23:11:56 +00:00

james.maes reopened this pull request 2026-11-05 23:11:58 +00:00

james.maes closed this pull request 2026-11-05 23:13:43 +00:00

james.maes reopened this pull request 2026-11-05 23:13:47 +00:00

james.maes merged commit c8ea97e54d into main 2026-11-05 23:14:50 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something isn't working

dependencies

documentation

Improvements or additions to documentation

duplicate

This issue or pull request already exists

enhancement

New feature or request

github_actions

Pull requests that update GitHub Actions code

good first issue

Good for newcomers

help wanted

Extra attention is needed

invalid

This doesn't seem right

question

Further information is requested

secuurity

wontfix

This will not be worked on

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

forge-recovery (Forge Recovery) james.maes (James Maes)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: QRun-IO/qqq-print-agent#10