test(presentation): record the companion's automation identifiers and hold them before the views are rebuilt #57
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: QRun-IO/qqq-print-agent#57
Reference in new issue
Block a user
Step 11 of the connection wizard build (ADR-0005): the automation identifiers the interactive UI tests find controls by are recorded, and held by tests, before the window is rewritten as a tree and a wizard.
What changes in the product
x:Name(Navigation,SupportLink) get an explicit identifier of the same value, so an automation client sees no rename.What the tests hold (
tests/Qqq.PrintAgent.Presentation.Tests/Views/, read as text; no reference to WinUI or the companion project)Server.<n>,Printer.<n>,Job.<n>) have a table that says where each may be produced; none is produced yet.Verification
9b542ceonrelease/2.0atc3bf23d.build/Verify.ps1passed on that head: 1,174 Core, 2,337 Windows runtime and command line, 1,110 presentation tests, none failed; Core 100% of 2,311 lines, presentation 100% of 2,236, command line 100%, Windows 96.06% (4,543 of 4,729; minimum 95).Review (independent reviewers)
1f480bc:0 blockers, 8 should-fix, 7 nits. The product part was confirmed clean; every should-fix was in the tests (a moved identifier passed; controls built in code and some lookups escaped).7fd04bd:0 blockers, 3 should-fix, 6 nits, all in the test readers.0e9816f:0 blockers, 2 should-fix, 6 nits, both in the test readers (a lookup whose identifier is built from a sum or a call was not read; one failure message gave advice that does not apply).0e9816ftob0206f3) answered those two and four nits, changed nothing undersrc, and was not sent through a fourth review: under the owner's merge rule of 2026-11-11, findings that are only about tests are recorded and merged. Its evidence: 136 single changes rerun with the reviewers' own runners; four results changed, all four intended. The coordinator added one documentation commit (9b542ce) correcting a sentence that pull request 56 made untrue.Recorded, for the step that rebuilds the views (plan step 12)
src/Qqq.PrintAgent/MainWindow.xaml.cs:71.Not proven here
The interactive UI tests and the layout harness were not run (they need an elevated interactive desktop). That FlaUI finds the 14 new identifiers, and what Narrator says, only an interactive run can show.
🤖 Generated with Claude Code
Answers the review of the identifier baseline (0 blockers, 8 should-fix, 7 nits). Nothing under src changes: the 121 identifiers are on the same controls. The tests, their readers and the recorded list change. An identifier that moves now fails. Each line of Views/automation-ids.txt is "Identifier | class | control": the view's class or the class the C# file declares, and the control as the readers describe it without a line number (for markup the tag and the x:Name, or the tag, the label and the nearest named element around it; for code the target of SetAutomationId, with the side of a choice or the call that forwarded the identifier). Two identifiers that swap controls are two changed lines. The class stands where the file's name would, so a file that is only renamed changes nothing. Two identified controls that the list could not tell apart fail, and so does an element without an identifier whose x:Name is another control's identifier, since WinUI reports the name. Controls created in code are read from every new in the companion. A creation is matched to a SetAutomationId of the same method, and of the same file only for a field or a property. Nullable declarations, global:: and namespaces are read; a new( whose type is written where the reader does not look fails. Code is held to the same lists of kinds as markup, with a fourth list for what code creates that is no element (values, commands, services), so a type in none of them fails. The message of the commit that added these tests ("test(presentation): hold the companion's identifiers and live regions to a recorded contract", reviewed as 00de256) said "a kind no view has had before fails until it is put in a list"; at that commit this held for markup only, and it holds for code from this one. A class of the companion needs no entry: it is what it derives from, and one with its own markup is a view. An identifier is read only from SetAutomationId; AutomationIdProperty, the method used as a delegate, and XamlReader fail with what to write instead. A helper that forwards an identifier is read from its callers in every file. The tray menu's items are excepted by the menu they are added to, which must be the one given to the TaskbarIcon, not by a count. An element that takes input (a handler for a press or a key, in markup or in code, or a tab stop) needs an identifier whatever its kind. Identifiers that are not written out are allowed only for the forms ADR-0005 and the plan's G17 give (Server.<n>, Printer.<n>, Job.<n>), each at the one place a table in the test names. Nothing produces them yet, and a test holds that: no such identifier is set, written or looked up. The view step fills in places; it does not change a rule. Both interactive suites are linked with every sub-folder. A mention of AutomationId in a suite outside a lookup the reader knows fails (an XPath, a property comparison, ==), and the harness's Field<T>(window, nameof(...)) is read. Every named TextBlock, RichTextBlock and InfoBar is now in one of three lists: status text, changes without being announced, never changes. x:DefaultBindMode is honoured, and a text written from another file or through a method that writes its parameter is seen. JobsSummary, StartupGuidanceText and ConnectionFeedback are listed as not announced today, to be decided in the view step, each with the fact that makes it a result (audit U28). The one announcement the window makes, for the footer, is held as text; declaring a live region is not announcing. Not seen, and said so in the readers: a control made without new in the companion, code in the holes of an interpolated string, a text that code creates, and what a screen reader says. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Signed-off-by: James Maes <james@kof22.com>