fix: let the browser-launched handler reach the elevated companion's callback inbox #9

Merged
james.maes merged 2 commits from fix/browser-callback-inbox-20261105 into main 2026-11-05 16:24:44 +00:00
Owner

Summary

  • Root cause of every failed browser sign-in: the companion runs elevated, and PipeOptions.CurrentUserOnly keyed the callback inbox to the elevated token's default owner (Administrators). The protocol handler the browser launches runs as the ordinary user with Administrators as a deny-only group, so it was refused with "Access to the path is denied" before reaching the app.
  • The inbox is now created through NamedPipeServerStreamAcl with an explicit descriptor: owner and single allow rule set to the user's own SID. The handler's client drops the owner comparison and relies on the existing process-image verification of the companion.
  • New tests: inbox descriptor shape, and a forwarded-callback round trip through the handler's client path.
  • Version 1.1.1; CHANGELOG updated. No wire change.

Verification

  • NativeCI solution: zero warnings. Qqq.PrintAgent.Cli.Tests: 351 passed.
  • Reproduced on the dev PC: unelevated connect to the inbox failed with access denied under the old descriptor; the forwarded-callback test passes with the new one. Installed acceptance of a full browser sign-in follows with the local 1.1.1 MSI.

Substantial AI assistance was used for this change.

🤖 Generated with Claude Code

## Summary - Root cause of every failed browser sign-in: the companion runs elevated, and `PipeOptions.CurrentUserOnly` keyed the callback inbox to the elevated token's default owner (Administrators). The protocol handler the browser launches runs as the ordinary user with Administrators as a deny-only group, so it was refused with "Access to the path is denied" before reaching the app. - The inbox is now created through `NamedPipeServerStreamAcl` with an explicit descriptor: owner and single allow rule set to the user's own SID. The handler's client drops the owner comparison and relies on the existing process-image verification of the companion. - New tests: inbox descriptor shape, and a forwarded-callback round trip through the handler's client path. - Version 1.1.1; CHANGELOG updated. No wire change. ## Verification - NativeCI solution: zero warnings. `Qqq.PrintAgent.Cli.Tests`: 351 passed. - Reproduced on the dev PC: unelevated connect to the inbox failed with access denied under the old descriptor; the forwarded-callback test passes with the new one. Installed acceptance of a full browser sign-in follows with the local 1.1.1 MSI. Substantial AI assistance was used for this change. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
james.maes added 1 commit 2026-11-05 15:57:40 +00:00
fix: let the browser-launched handler reach the elevated companion's callback inbox
QRun-IO/ci-policy: ci / fork-guard (pull_request) Skipped
QRun-IO/ci-policy: native / fork-deny (pull_request) Skipped
QRun-IO/ci-policy: ci / Scoped workflow [workflow 5e6bfd71ee8a5674882f7680c695a0ada599622f] (pull_request) Successful in 9s
QRun-IO/ci-policy: ci / head-profile (pull_request) Skipped
QRun-IO/ci-policy: ci / repository-policy (pull_request) Skipped
QRun-IO/ci-policy: ci / application-template-0 (pull_request) Skipped
QRun-IO/ci-policy: ci / gradle-1 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-core-2-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-3 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-3-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-4 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-frontend-browser-5 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-6 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-6-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-7 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-7-head (pull_request) Skipped
QRun-IO/ci-policy: ci / node-8 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-9 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-10 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-playwright-11 (pull_request) Skipped
QRun-IO/ci-policy: ci / repository-policy-12 (pull_request) Skipped
QRun-IO/ci-policy: ci / source-config-13 (pull_request) Skipped
QRun-IO/ci-policy: ci / android-0 (pull_request) Skipped
QRun-IO/ci-policy: ci / original-business (pull_request) Skipped
QRun-IO/ci-policy: ci / original-mcp (pull_request) Skipped
QRun-IO/ci-policy: ci / original-voyage (pull_request) Skipped
QRun-IO/ci-policy: ci / original-cli (pull_request) Skipped
QRun-IO/ci-policy: ci / not-enrolled (pull_request) Skipped
QRun-IO/ci-policy: ci / shared-pipeline (pull_request) Skipped
QRun-IO/ci-policy: Shared .NET CI / secrets (pull_request) Successful in 29s
QRun-IO/ci-policy: Shared .NET CI / verify (pull_request) Skipped
QRun-IO/ci-policy: Shared source and config CI / verify (pull_request) Successful in 24s
QRun-IO/ci-policy: Shared .NET CI / portable (pull_request) Skipped
QRun-IO/ci-policy: Shared source and config CI / secrets (pull_request) Successful in 28s
QRun-IO/ci-policy: Shared source and config CI / gate (pull_request) Successful in 15s
QRun-IO/ci-policy: ci / source-config-14 (pull_request) Successful in 49s
QRun-IO/ci-policy: ci / ci-result (pull_request) Successful in 7s
QRun-IO/ci-policy: Shared .NET CI / gate (pull_request) Canceled after 0s
QRun-IO/ci-policy: native / native-result (pull_request) Canceled after 0s
QRun-IO/ci-policy: Shared .NET CI / hosted (pull_request) Canceled after 2m37s
QRun-IO/ci-policy: native / dotnet-0 (pull_request) Canceled after 2m36s
e63cf02b06
PipeOptions.CurrentUserOnly keyed the inbox to the elevated token's default owner
(Administrators), so the unelevated protocol handler was refused and no browser sign-in
could complete. The inbox now carries an explicit descriptor owned by and restricted to the
user's SID; the handler verifies the companion by process image instead of the owner check.
Adds inbox security and round-trip tests. Version 1.1.1.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
james.maes added 1 commit 2026-11-05 16:00:07 +00:00
test: assert the live inbox pipe is owned by the user, not the token's default owner
QRun-IO/ci-policy: ci / fork-guard (pull_request) Skipped
QRun-IO/ci-policy: ci / Scoped workflow [workflow 5e6bfd71ee8a5674882f7680c695a0ada599622f] (pull_request) Successful in 8s
QRun-IO/ci-policy: native / fork-deny (pull_request) Skipped
QRun-IO/ci-policy: Shared .NET CI / verify (pull_request) Skipped
QRun-IO/ci-policy: Shared .NET CI / portable (pull_request) Skipped
QRun-IO/ci-policy: ci / head-profile (pull_request) Skipped
QRun-IO/ci-policy: ci / repository-policy (pull_request) Skipped
QRun-IO/ci-policy: ci / application-template-0 (pull_request) Skipped
QRun-IO/ci-policy: ci / gradle-1 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-core-2-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-3 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-3-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-docker-4 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-frontend-browser-5 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-6 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-6-head (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-7 (pull_request) Skipped
QRun-IO/ci-policy: ci / java-maven-7-head (pull_request) Skipped
QRun-IO/ci-policy: ci / node-8 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-9 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-10 (pull_request) Skipped
QRun-IO/ci-policy: ci / node-playwright-11 (pull_request) Skipped
QRun-IO/ci-policy: ci / repository-policy-12 (pull_request) Skipped
QRun-IO/ci-policy: ci / source-config-13 (pull_request) Skipped
QRun-IO/ci-policy: ci / android-0 (pull_request) Skipped
QRun-IO/ci-policy: ci / original-business (pull_request) Skipped
QRun-IO/ci-policy: ci / original-mcp (pull_request) Skipped
QRun-IO/ci-policy: ci / original-voyage (pull_request) Skipped
QRun-IO/ci-policy: ci / original-cli (pull_request) Skipped
QRun-IO/ci-policy: ci / not-enrolled (pull_request) Skipped
QRun-IO/ci-policy: ci / shared-pipeline (pull_request) Skipped
QRun-IO/ci-policy: Shared source and config CI / verify (pull_request) Successful in 21s
QRun-IO/ci-policy: Shared .NET CI / secrets (pull_request) Successful in 27s
QRun-IO/ci-policy: Shared source and config CI / secrets (pull_request) Successful in 27s
QRun-IO/ci-policy: Shared source and config CI / gate (pull_request) Successful in 16s
QRun-IO/ci-policy: ci / source-config-14 (pull_request) Successful in 45s
QRun-IO/ci-policy: ci / ci-result (pull_request) Successful in 6s
QRun-IO/ci-policy: Shared .NET CI / hosted (pull_request) Successful in 23m13s
QRun-IO/ci-policy: Shared .NET CI / gate (pull_request) Successful in 19s
QRun-IO/ci-policy: native / dotnet-0 (pull_request) Successful in 23m54s
QRun-IO/ci-policy: native / native-result (pull_request) Successful in 7s
cd7c0f7e1f
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
james.maes merged commit f954f11243 into main 2026-11-05 16:24:44 +00:00
Sign in to join this conversation.