fix(app): an account's page takes no token it would ignore, and Sync all does not call an unsynced account synced #185

Merged
james.maes merged 2 commits from fix/182-account-token-box-and-sync-all-result into main 2026-11-11 06:20:31 +00:00
2 Commits
Author SHA1 Message Date
james.maesandClaude Fable 5.2 d75bd4bd87 fix(app): second review of #185: every account is counted once in the Sync all result, and Retry failed does not touch the selection
- The result sentence says how many of how many accounts were synced, then
  each group that was not, once: an account that could not be synced needs
  attention and is no longer 'skipped' as well (SyncAllResult.CouldNotSync,
  Total).
- Retry failed runs the failed rows without changing the selection at all, so
  there is nothing to give back and a change made while it runs stays.
- The account's page says what to do in the window's own words (no Credential
  Manager entry name), also for an account on the default token; the line is
  announced when it changes.

Refs #182

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
2026-11-11 00:19:49 -06:00
james.maesandClaude Fable 5.2 117e8959ca fix(app): an account's page takes no token it would ignore, and Sync all does not call an unsynced account synced
Findings of the release reviews of 1.1.1, each reproduced against the view
models before it was fixed.

- An account's token is read from where it is saved each time it is used
  (#158), so a token typed into the box on an account's page looked taken and
  was not used. The box of an account takes no input now; the page says the
  token is set with Edit account, offers that button, and says why Load cannot
  run when the account has no token. Quick Sync keeps its box.
- Sync all: an account that could not be synced (no token, repositories that
  could not be loaded) is marked as needing attention and the pass ends as
  finished with failures, instead of a green "0 accounts synced, 1 skipped".
  An account whose own sync was canceled is not counted as synced. A canceled
  pass says how many accounts were not started.
- Retry failed gives the selection back when its run is over. Left narrowed, a
  later Sync or Sync all synced only the rows that had failed and reported the
  account as synced.
- "1 repository", not "1 repositories".

Closes #182

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Signed-off-by: James Maes <james@kof22.com>
2026-11-10 23:57:09 -06:00