KofTwentyTwo/gclo
2
0 Fork 0
Code Issues 28 Pull Requests 1 Actions Packages Projects Releases 22 Wiki Activity

ci(release): sign off the generated packaging commit #82

Merged
KofTwentyTwo merged 1 commits from ci/GH-81-packaging-signoff into main 2026-10-10 16:45:51 +00:00
Conversation 0 Commits 1 Files Changed 1
+6
KofTwentyTwo commented 2026-10-10 15:00:42 +00:00 (Migrated from github.com)
Copy link
Copy source

What

The packages job's build(packaging): … pull request is generated by peter-evans/create-pull-request, and its commit carried no Signed-off-by: trailer, so the standards' pr / dco gate (which needs a sign-off matching the commit author) failed on the first real one, #80 for v1.0.1. The action now sets author and committer to the same identity (the actor who pushed the tag, <id>+<login>@users.noreply.github.com) and signoff: true, so the trailer it adds matches the author the check compares against.

Closes #81 (part of #62). #80 itself needs its commit amended with a sign-off (or an admin merge); this PR fixes every later release.

How it was tested

  • actionlint clean.
  • The three inputs exist on the pinned create-pull-request v8.1.1 (checked action.yml at the SHA).
  • Not exercised on a tag: the next stable release is the first run.

🤖 Generated with Claude Code

## What The `packages` job's `build(packaging): …` pull request is generated by `peter-evans/create-pull-request`, and its commit carried no `Signed-off-by:` trailer, so the standards' `pr / dco` gate (which needs a sign-off matching the commit author) failed on the first real one, #80 for v1.0.1. The action now sets `author` and `committer` to the same identity (the actor who pushed the tag, `<id>+<login>@users.noreply.github.com`) and `signoff: true`, so the trailer it adds matches the author the check compares against. Closes #81 (part of #62). #80 itself needs its commit amended with a sign-off (or an admin merge); this PR fixes every later release. ## How it was tested - `actionlint` clean. - The three inputs exist on the pinned `create-pull-request` v8.1.1 (checked `action.yml` at the SHA). - Not exercised on a tag: the next stable release is the first run. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
.NET
Pull requests that update .NET code
 bug
Something isn't working
 deferred
Agreed follow-up, not scheduled
 dependencies
Pull requests that update a dependency file
 documentation
Improvements or additions to documentation
 duplicate
This issue or pull request already exists
 enhancement
New feature or request
 github_actions
Pull requests that update GitHub Actions code
 good first issue
Good for newcomers
 help wanted
Extra attention is needed
 invalid
This doesn't seem right
 needs-owner
Blocked on an action only the owner can take
 priority
Owner-flagged: work this first
 quality
Standards, simplicity, enforcement
 question
Further information is requested
 refactor
Restructuring without behavior change
 release
Release pipeline / distribution
 wontfix
This will not be worked on
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
forge-recovery (Forge Recovery) james.maes (James Maes)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: KofTwentyTwo/gclo#82